Re: [Qemu-devel] [PATCH v2] ivshmem: use error_report

2014-10-07 Thread Andrew Jones
On Mon, Sep 22, 2014 at 02:20:09PM +0300, Michael S. Tsirkin wrote: > On Fri, Sep 19, 2014 at 04:42:59PM +0800, zhanghailiang wrote: > > On 2014/9/19 15:34, zhanghailiang wrote: > > >On 2014/9/19 7:17, Andrew Jones wrote: > > >>Replace all the fprintf(stderr, ...) calls with error_report. > > >>Als

Re: [Qemu-devel] [PATCH v2] ivshmem: use error_report

2014-09-22 Thread Michael S. Tsirkin
On Fri, Sep 19, 2014 at 04:42:59PM +0800, zhanghailiang wrote: > On 2014/9/19 15:34, zhanghailiang wrote: > >On 2014/9/19 7:17, Andrew Jones wrote: > >>Replace all the fprintf(stderr, ...) calls with error_report. > >>Also make sure exit() consistently uses the error code 1. A few calls > >>used -1

Re: [Qemu-devel] [PATCH v2] ivshmem: use error_report

2014-09-19 Thread zhanghailiang
On 2014/9/19 15:34, zhanghailiang wrote: On 2014/9/19 7:17, Andrew Jones wrote: Replace all the fprintf(stderr, ...) calls with error_report. Also make sure exit() consistently uses the error code 1. A few calls used -1. Signed-off-by: Andrew Jones --- hw/misc/ivshmem.c | 39

Re: [Qemu-devel] [PATCH v2] ivshmem: use error_report

2014-09-19 Thread zhanghailiang
On 2014/9/19 7:17, Andrew Jones wrote: Replace all the fprintf(stderr, ...) calls with error_report. Also make sure exit() consistently uses the error code 1. A few calls used -1. Signed-off-by: Andrew Jones --- hw/misc/ivshmem.c | 39 +++ 1 file changed,

Re: [Qemu-devel] [PATCH v2] ivshmem: use error_report

2014-09-19 Thread David Marchand
On 09/19/2014 01:17 AM, Andrew Jones wrote: Replace all the fprintf(stderr, ...) calls with error_report. Also make sure exit() consistently uses the error code 1. A few calls used -1. Signed-off-by: Andrew Jones --- hw/misc/ivshmem.c | 39 +++ 1 file chan

[Qemu-devel] [PATCH v2] ivshmem: use error_report

2014-09-18 Thread Andrew Jones
Replace all the fprintf(stderr, ...) calls with error_report. Also make sure exit() consistently uses the error code 1. A few calls used -1. Signed-off-by: Andrew Jones --- hw/misc/ivshmem.c | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-) diff --g