Re: [Qemu-devel] [PATCH v2] libvhost-user: fix SLAVE_SEND_FD handling

2019-09-04 Thread Tiwei Bie
On Wed, Sep 04, 2019 at 10:06:55AM +0800, Tiwei Bie wrote: > On Tue, Sep 03, 2019 at 11:04:22PM +0300, Johannes Berg wrote: > > From: Johannes Berg > > > > It doesn't look like this could possibly work properly since > > VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD is defined to 10, but the > >

Re: [Qemu-devel] [PATCH v2] libvhost-user: fix SLAVE_SEND_FD handling

2019-09-03 Thread Tiwei Bie
On Tue, Sep 03, 2019 at 11:04:22PM +0300, Johannes Berg wrote: > From: Johannes Berg > > It doesn't look like this could possibly work properly since > VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD is defined to 10, but the > dev->protocol_features has a bitmap. I suppose the peer this > was tested with

[Qemu-devel] [PATCH v2] libvhost-user: fix SLAVE_SEND_FD handling

2019-09-03 Thread Johannes Berg
From: Johannes Berg It doesn't look like this could possibly work properly since VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD is defined to 10, but the dev->protocol_features has a bitmap. I suppose the peer this was tested with also supported VHOST_USER_PROTOCOL_F_LOG_SHMFD, in which case the test would