[Qemu-devel] [PATCH v2] main-loop: fix qemu_notify_event for aio_notify optimization

2015-07-24 Thread Paolo Bonzini
aio_notify can be optimized away, and in fact almost always will. However, qemu_notify_event is used in places where this is incorrect---most notably, when handling SIGTERM. When aio_notify is optimized away, it is possible that QEMU enters a blocking ppoll immediately afterwards and stays there,

Re: [Qemu-devel] [PATCH v2] main-loop: fix qemu_notify_event for aio_notify optimization

2015-07-27 Thread Stefan Hajnoczi
On Fri, Jul 24, 2015 at 01:42:55PM +0200, Paolo Bonzini wrote: > aio_notify can be optimized away, and in fact almost always will. However, > qemu_notify_event is used in places where this is incorrect---most notably, > when handling SIGTERM. When aio_notify is optimized away, it is possible that

Re: [Qemu-devel] [PATCH v2] main-loop: fix qemu_notify_event for aio_notify optimization

2015-07-27 Thread Peter Maydell
On 24 July 2015 at 12:42, Paolo Bonzini wrote: > aio_notify can be optimized away, and in fact almost always will. However, > qemu_notify_event is used in places where this is incorrect---most notably, > when handling SIGTERM. When aio_notify is optimized away, it is possible that > QEMU enters