Re: [Qemu-devel] [PATCH v2] net/colo-compare.c: Fix a crash in COLO Primary.

2019-05-06 Thread Jason Wang
On 2019/5/6 下午6:32, Lukas Straub wrote: On Sat, 20 Apr 2019 19:14:25 +0200 Lukas Straub wrote: From: Lukas Straub Because event_unhandled_count may be accessed concurrently, it needs to be protected by taking the lock. However the assert is outside the lock, probably causing it to read garb

Re: [Qemu-devel] [PATCH v2] net/colo-compare.c: Fix a crash in COLO Primary.

2019-05-06 Thread Philippe Mathieu-Daudé
Cc'ing Paolo & Stefan On 4/20/19 7:14 PM, Lukas Straub wrote: > From: Lukas Straub > Because event_unhandled_count may be accessed concurrently, it needs > to be protected by taking the lock. However the assert is outside the > lock, probably causing it to read garbage and aborting Qemu erroneous

Re: [Qemu-devel] [PATCH v2] net/colo-compare.c: Fix a crash in COLO Primary.

2019-05-06 Thread Lukas Straub
On Sat, 20 Apr 2019 19:14:25 +0200 Lukas Straub wrote: > From: Lukas Straub > Because event_unhandled_count may be accessed concurrently, it needs > to be protected by taking the lock. However the assert is outside the > lock, probably causing it to read garbage and aborting Qemu > erroneously.

Re: [Qemu-devel] [PATCH v2] net/colo-compare.c: Fix a crash in COLO Primary.

2019-04-23 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub [mailto:lukasstra...@web.de] > Sent: Sunday, April 21, 2019 1:14 AM > To: qemu-devel@nongnu.org > Cc: Zhang, Chen > Subject: [PATCH v2] net/colo-compare.c: Fix a crash in COLO Primary. > > From: Lukas Straub Because event_unhandled_count > may

Re: [Qemu-devel] [PATCH v2] net/colo-compare.c: Fix a crash in COLO Primary.

2019-04-21 Thread Philippe Mathieu-Daudé
On 4/20/19 7:14 PM, Lukas Straub wrote: > From: Lukas Straub > Because event_unhandled_count may be accessed concurrently, it needs > to be protected by taking the lock. However the assert is outside the > lock, probably causing it to read garbage and aborting Qemu erroneously. > > The Bug only h

[Qemu-devel] [PATCH v2] net/colo-compare.c: Fix a crash in COLO Primary.

2019-04-20 Thread Lukas Straub
From: Lukas Straub Because event_unhandled_count may be accessed concurrently, it needs to be protected by taking the lock. However the assert is outside the lock, probably causing it to read garbage and aborting Qemu erroneously. The Bug only happens when running Qemu in COLO mode. This Patch f