Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-14 Thread Fam Zheng
On Tue, 07/14 15:42, Michael S. Tsirkin wrote: > On Tue, Jul 14, 2015 at 01:20:03PM +0100, Stefan Hajnoczi wrote: > > On Fri, Jul 10, 2015 at 05:03:22PM +0800, Fam Zheng wrote: > > > On Tue, 07/07 12:19, Michael S. Tsirkin wrote: > > > > On Tue, Jul 07, 2015 at 05:09:09PM +0800, Fam Zheng wrote: >

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-14 Thread Michael S. Tsirkin
On Tue, Jul 14, 2015 at 01:20:03PM +0100, Stefan Hajnoczi wrote: > On Fri, Jul 10, 2015 at 05:03:22PM +0800, Fam Zheng wrote: > > On Tue, 07/07 12:19, Michael S. Tsirkin wrote: > > > On Tue, Jul 07, 2015 at 05:09:09PM +0800, Fam Zheng wrote: > > > > On Tue, 07/07 11:13, Michael S. Tsirkin wrote: >

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-14 Thread Stefan Hajnoczi
On Fri, Jul 10, 2015 at 05:03:22PM +0800, Fam Zheng wrote: > On Tue, 07/07 12:19, Michael S. Tsirkin wrote: > > On Tue, Jul 07, 2015 at 05:09:09PM +0800, Fam Zheng wrote: > > > On Tue, 07/07 11:13, Michael S. Tsirkin wrote: > > > > On Tue, Jul 07, 2015 at 09:21:07AM +0800, Fam Zheng wrote: > > > >

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-12 Thread Jason Wang
On 07/10/2015 05:24 PM, Fam Zheng wrote: > On Wed, 07/08 17:40, Jason Wang wrote: >> >> On 07/07/2015 05:03 PM, Fam Zheng wrote: >>> On Tue, 07/07 15:44, Jason Wang wrote: On 07/07/2015 09:21 AM, Fam Zheng wrote: > Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends,

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-10 Thread Fam Zheng
On Wed, 07/08 17:40, Jason Wang wrote: > > > On 07/07/2015 05:03 PM, Fam Zheng wrote: > > On Tue, 07/07 15:44, Jason Wang wrote: > >> > >> On 07/07/2015 09:21 AM, Fam Zheng wrote: > >>> Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, > >>> net queues need to be explicitly

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-10 Thread Fam Zheng
On Tue, 07/07 12:19, Michael S. Tsirkin wrote: > On Tue, Jul 07, 2015 at 05:09:09PM +0800, Fam Zheng wrote: > > On Tue, 07/07 11:13, Michael S. Tsirkin wrote: > > > On Tue, Jul 07, 2015 at 09:21:07AM +0800, Fam Zheng wrote: > > > > Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and fri

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-09 Thread Stefan Hajnoczi
On Tue, Jul 07, 2015 at 12:10:15PM +0300, Michael S. Tsirkin wrote: > On Tue, Jul 07, 2015 at 04:58:29PM +0800, Jason Wang wrote: > > > > > > On 07/07/2015 04:13 PM, Michael S. Tsirkin wrote: > > > On Tue, Jul 07, 2015 at 09:21:07AM +0800, Fam Zheng wrote: > > >> Since commit 6e99c63 "net/socket:

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-08 Thread Jason Wang
On 07/07/2015 05:03 PM, Fam Zheng wrote: > On Tue, 07/07 15:44, Jason Wang wrote: >> >> On 07/07/2015 09:21 AM, Fam Zheng wrote: >>> Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, >>> net queues need to be explicitly flushed after qemu_can_send_packet() >>> returns false

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-07 Thread Fam Zheng
On Tue, 07/07 12:10, Michael S. Tsirkin wrote: > On Tue, Jul 07, 2015 at 04:58:29PM +0800, Jason Wang wrote: > > > > > > On 07/07/2015 04:13 PM, Michael S. Tsirkin wrote: > > > On Tue, Jul 07, 2015 at 09:21:07AM +0800, Fam Zheng wrote: > > >> Since commit 6e99c63 "net/socket: Drop net_socket_can_

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-07 Thread Michael S. Tsirkin
On Tue, Jul 07, 2015 at 05:09:09PM +0800, Fam Zheng wrote: > On Tue, 07/07 11:13, Michael S. Tsirkin wrote: > > On Tue, Jul 07, 2015 at 09:21:07AM +0800, Fam Zheng wrote: > > > Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, > > > net queues need to be explicitly flushed af

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-07 Thread Michael S. Tsirkin
On Tue, Jul 07, 2015 at 04:58:29PM +0800, Jason Wang wrote: > > > On 07/07/2015 04:13 PM, Michael S. Tsirkin wrote: > > On Tue, Jul 07, 2015 at 09:21:07AM +0800, Fam Zheng wrote: > >> Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, > >> net queues need to be explicitly fl

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-07 Thread Fam Zheng
On Tue, 07/07 11:13, Michael S. Tsirkin wrote: > On Tue, Jul 07, 2015 at 09:21:07AM +0800, Fam Zheng wrote: > > Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, > > net queues need to be explicitly flushed after qemu_can_send_packet() > > returns false, because the netdev si

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-07 Thread Fam Zheng
On Tue, 07/07 15:44, Jason Wang wrote: > > > On 07/07/2015 09:21 AM, Fam Zheng wrote: > > Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, > > net queues need to be explicitly flushed after qemu_can_send_packet() > > returns false, because the netdev side will disable the

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-07 Thread Jason Wang
On 07/07/2015 04:13 PM, Michael S. Tsirkin wrote: > On Tue, Jul 07, 2015 at 09:21:07AM +0800, Fam Zheng wrote: >> Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, >> net queues need to be explicitly flushed after qemu_can_send_packet() >> returns false, because the netdev

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-07 Thread Stefan Hajnoczi
On Tue, Jul 07, 2015 at 09:21:07AM +0800, Fam Zheng wrote: > Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, > net queues need to be explicitly flushed after qemu_can_send_packet() > returns false, because the netdev side will disable the polling of fd. > > This fixes the

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-07 Thread Michael S. Tsirkin
On Tue, Jul 07, 2015 at 09:21:07AM +0800, Fam Zheng wrote: > Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, > net queues need to be explicitly flushed after qemu_can_send_packet() > returns false, because the netdev side will disable the polling of fd. > > This fixes the

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-07 Thread Jason Wang
On 07/07/2015 09:21 AM, Fam Zheng wrote: > Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, > net queues need to be explicitly flushed after qemu_can_send_packet() > returns false, because the netdev side will disable the polling of fd. > > This fixes the case of "cont" af

[Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-06 Thread Fam Zheng
Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, net queues need to be explicitly flushed after qemu_can_send_packet() returns false, because the netdev side will disable the polling of fd. This fixes the case of "cont" after "stop" (or migration). Signed-off-by: Fam Zheng