[Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread arei.gonglei
From: Gonglei because mmsghdr struct is introduced on Linux kernel 3.3+. add check for mmsghdr struct, it only gets built on hosts that support mmsghdr. Reported-by: chenliang Signed-off-by: Gonglei --- v2->v1: delete $l2tpv3 variable initialization and 'if' false check suggested by PM

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Stefan Hajnoczi
On Tue, Jul 1, 2014 at 2:58 PM, wrote: > From: Gonglei > > because mmsghdr struct is introduced on Linux kernel 3.3+. > add check for mmsghdr struct, it only gets built on hosts that > support mmsghdr. > > Reported-by: chenliang > Signed-off-by: Gonglei > --- > v2->v1: >delete $l2tpv3 vari

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Anton Ivanov (antivano)
On 01/07/14 15:35, Stefan Hajnoczi wrote: > On Tue, Jul 1, 2014 at 2:58 PM, wrote: >> From: Gonglei >> >> because mmsghdr struct is introduced on Linux kernel 3.3+. >> add check for mmsghdr struct, it only gets built on hosts that >> support mmsghdr. Incorrect. mmsghdr itself is Linux 2.6.32 a

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Peter Maydell
On 1 July 2014 16:06, Anton Ivanov (antivano) wrote: > As far as general purpose linuxes, the relevant libc headers are present > in Ubuntul LTS 12.x and onwards, Debian 7.x, Fedora, and all other major > distros. I do not have a RHEL handy to check, but looking at release > notes that the kernel

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Anton Ivanov (antivano)
On 01/07/14 16:14, Peter Maydell wrote: > On 1 July 2014 16:06, Anton Ivanov (antivano) wrote: >> As far as general purpose linuxes, the relevant libc headers are present >> in Ubuntul LTS 12.x and onwards, Debian 7.x, Fedora, and all other major >> distros. I do not have a RHEL handy to check, bu

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Peter Maydell
On 1 July 2014 16:26, Anton Ivanov (antivano) wrote: > On 01/07/14 16:14, Peter Maydell wrote: >> On 1 July 2014 16:06, Anton Ivanov (antivano) wrote: >>> As far as general purpose linuxes, the relevant libc headers are present >>> in Ubuntul LTS 12.x and onwards, Debian 7.x, Fedora, and all othe

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Anton Ivanov (antivano)
On 01/07/14 16:34, Peter Maydell wrote: > On 1 July 2014 16:26, Anton Ivanov (antivano) wrote: >> On 01/07/14 16:14, Peter Maydell wrote: >>> On 1 July 2014 16:06, Anton Ivanov (antivano) wrote: As far as general purpose linuxes, the relevant libc headers are present in Ubuntul LTS 12.x

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Peter Maydell
On 1 July 2014 16:58, Anton Ivanov (antivano) wrote: > On 01/07/14 16:34, Peter Maydell wrote: >> We don't need to support this optional feature on RHEL5, we >> just need not to die horribly trying to compile it when we're >> on an older system, that's all. This patch should be enough for >> this,

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Peter Maydell
On 1 July 2014 13:58, wrote: > From: Gonglei > > because mmsghdr struct is introduced on Linux kernel 3.3+. > add check for mmsghdr struct, it only gets built on hosts that > support mmsghdr. > > Reported-by: chenliang > Signed-off-by: Gonglei Applied to master (with a tweaked commit message)

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Gonglei (Arei)
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Wednesday, July 02, 2014 1:27 AM > To: Gonglei (Arei) > Cc: QEMU Developers; Anton Ivanov (antivano); Stefan Hajnoczi; Paolo Bonzini; > Huangweidong (C); Luonengjun; chenliang (T) > Subject: Re: [PATCH v2]

Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for L2TPV3

2014-07-01 Thread Gonglei (Arei)
zini > Subject: Re: [Qemu-devel] [PATCH v2] net: add mmsghdr struct check for > L2TPV3 > > On 01/07/14 15:35, Stefan Hajnoczi wrote: > > On Tue, Jul 1, 2014 at 2:58 PM, wrote: > >> From: Gonglei > >> > >> because mmsghdr struct is introduced on Lin