Re: [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-14 Thread Ramon Fried
On Wed, Jun 12, 2019 at 10:40 AM Laurent Vivier wrote: > Le 12/06/2019 à 06:27, Ramon Fried a écrit : > > > > > > On Tue, Jun 11, 2019 at 7:21 PM Laurent Vivier > > wrote: > > > > Le 11/06/2019 à 16:55, Ramon Fried a écrit : > > > defining CADENCE_GEM_ERR_DEBUG

Re: [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-12 Thread Philippe Mathieu-Daudé
On 6/11/19 4:55 PM, Ramon Fried wrote: > defining CADENCE_GEM_ERR_DEBUG causes compilation > errors, fix that. > > Signed-off-by: Ramon Fried > --- > v2: change %lx to HWADDR_PRIx and %lx to %zdx > > hw/net/cadence_gem.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-12 Thread Laurent Vivier
Le 12/06/2019 à 06:27, Ramon Fried a écrit : > > > On Tue, Jun 11, 2019 at 7:21 PM Laurent Vivier > wrote: > > Le 11/06/2019 à 16:55, Ramon Fried a écrit : > > defining CADENCE_GEM_ERR_DEBUG causes compilation > > errors, fix that. > > > > Signed-of

Re: [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-11 Thread Ramon Fried
On Tue, Jun 11, 2019 at 7:21 PM Laurent Vivier wrote: > Le 11/06/2019 à 16:55, Ramon Fried a écrit : > > defining CADENCE_GEM_ERR_DEBUG causes compilation > > errors, fix that. > > > > Signed-off-by: Ramon Fried > > --- > > v2: change %lx to HWADDR_PRIx and %lx to %zdx > > HWADDR_PRIx is to use

Re: [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-11 Thread Laurent Vivier
Le 11/06/2019 à 16:55, Ramon Fried a écrit : > defining CADENCE_GEM_ERR_DEBUG causes compilation > errors, fix that. > > Signed-off-by: Ramon Fried > --- > v2: change %lx to HWADDR_PRIx and %lx to %zdx HWADDR_PRIx is to use with hwaddr type (packet_desc_addr). rx_desc_get_buffer() is uint64_t, y

[Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-11 Thread Ramon Fried
defining CADENCE_GEM_ERR_DEBUG causes compilation errors, fix that. Signed-off-by: Ramon Fried --- v2: change %lx to HWADDR_PRIx and %lx to %zdx hw/net/cadence_gem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 7f634