Re: [Qemu-devel] [PATCH v2] net: rocker: fix an incorrect array bounds check

2015-12-28 Thread Jason Wang
On 12/28/2015 06:54 PM, P J P wrote: > From: Prasad J Pandit > > While processing transmit(tx) descriptors in 'tx_consume' routine > the switch emulator suffers from an off-by-one error, if a > descriptor was to have more than allowed(ROCKER_TX_FRAGS_MAX=16) > fragments.

[Qemu-devel] [PATCH v2] net: rocker: fix an incorrect array bounds check

2015-12-28 Thread P J P
From: Prasad J Pandit While processing transmit(tx) descriptors in 'tx_consume' routine the switch emulator suffers from an off-by-one error, if a descriptor was to have more than allowed(ROCKER_TX_FRAGS_MAX=16) fragments. Fix an incorrect bounds check to avoid it.

Re: [Qemu-devel] [PATCH v2] net: rocker: fix an incorrect array bounds check

2015-12-28 Thread P J P
Hello Jason, all +-- On Mon, 28 Dec 2015, Jason Wang wrote --+ | On 12/23/2015 01:14 PM, P J P wrote: | > +-- On Tue, 22 Dec 2015, Peter Maydell wrote --+ | > | Could you submit patches in the usual git send-email format, | > | please? | > | > Yes, surely will do. I did read about it here[*],

Re: [Qemu-devel] [PATCH v2] net: rocker: fix an incorrect array bounds check

2015-12-27 Thread Jason Wang
On 12/23/2015 01:14 PM, P J P wrote: > +-- On Tue, 22 Dec 2015, Peter Maydell wrote --+ > | Could you submit patches in the usual git send-email format, > | please? It's easier for maintainers to process them if they're > | not in an odd arrangement that requires manual intervention. > | (In

[Qemu-devel] [PATCH v2] net: rocker: fix an incorrect array bounds check

2015-12-22 Thread P J P
Hello Paolo, all Please see an updated patch below, as per suggestion in -> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04057.html === From 344a487d637be20b3fb110bec36cb703e7f6ecaa Mon Sep 17 00:00:00 2001 From: Prasad J Pandit Date: Wed, 23 Dec 2015

Re: [Qemu-devel] [PATCH v2] net: rocker: fix an incorrect array bounds check

2015-12-22 Thread Peter Maydell
On 22 December 2015 at 19:24, P J P wrote: > Hello Paolo, all > > Please see an updated patch below, as per suggestion in > -> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04057.html Could you submit patches in the usual git send-email format, please? It's

Re: [Qemu-devel] [PATCH v2] net: rocker: fix an incorrect array bounds check

2015-12-22 Thread P J P
+-- On Tue, 22 Dec 2015, Peter Maydell wrote --+ | Could you submit patches in the usual git send-email format, | please? It's easier for maintainers to process them if they're | not in an odd arrangement that requires manual intervention. | (In particular, comments that aren't intended to go in

Re: [Qemu-devel] [PATCH v2] net: rocker: fix an incorrect array bounds check

2015-12-22 Thread Stefan Hajnoczi
On Wed, Dec 23, 2015 at 12:54:18AM +0530, P J P wrote: > Hello Paolo, all > > Please see an updated patch below, as per suggestion in > -> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04057.html Adding Jason Wang (net maintainer) on CC. > === > >From