Re: [Qemu-devel] [PATCH v2] pc: Don't make die-id mandatory unless necessary

2021-02-03 Thread Philippe Mathieu-Daudé
Cc'ing avocado-devel for test ideas. On 8/28/19 6:57 PM, Igor Mammedov wrote: > On Wed, 28 Aug 2019 11:35:24 -0300 > Eduardo Habkost wrote: > >> On Wed, Aug 28, 2019 at 08:52:28AM +0200, Markus Armbruster wrote: ... >>> In addition, I'd like us to either work on making the rule stick in the >>>

Re: [Qemu-devel] [PATCH v2] pc: Don't make die-id mandatory unless necessary

2019-08-29 Thread Peter Krempa
On Thu, Aug 29, 2019 at 15:12:33 +0200, Peter Krempa wrote: > On Wed, Aug 28, 2019 at 18:57:18 +0200, Igor Mammedov wrote: > > On Wed, 28 Aug 2019 11:35:24 -0300 [...] > > Also if we would need to change implicit values logic down the road > > it would be a pain like with any default parameters

Re: [Qemu-devel] [PATCH v2] pc: Don't make die-id mandatory unless necessary

2019-08-29 Thread Peter Krempa
On Wed, Aug 28, 2019 at 18:57:18 +0200, Igor Mammedov wrote: > On Wed, 28 Aug 2019 11:35:24 -0300 > Eduardo Habkost wrote: > > > On Wed, Aug 28, 2019 at 08:52:28AM +0200, Markus Armbruster wrote: > > > Eduardo Habkost writes: > > > > > > > We have this issue reported when using libvirt to

Re: [Qemu-devel] [PATCH v2] pc: Don't make die-id mandatory unless necessary

2019-08-28 Thread Igor Mammedov
On Wed, 28 Aug 2019 11:35:24 -0300 Eduardo Habkost wrote: > On Wed, Aug 28, 2019 at 08:52:28AM +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > > We have this issue reported when using libvirt to hotplug CPUs: > > > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 > > >

Re: [Qemu-devel] [PATCH v2] pc: Don't make die-id mandatory unless necessary

2019-08-28 Thread Eduardo Habkost
On Wed, Aug 28, 2019 at 08:52:28AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > We have this issue reported when using libvirt to hotplug CPUs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 > > > > Basically, libvirt is not copying die-id from > >

Re: [Qemu-devel] [PATCH v2] pc: Don't make die-id mandatory unless necessary

2019-08-28 Thread Markus Armbruster
Eduardo Habkost writes: > We have this issue reported when using libvirt to hotplug CPUs: > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 > > Basically, libvirt is not copying die-id from > query-hotpluggable-cpus, but die-id is now mandatory. > > We could blame libvirt and say it is not

Re: [Qemu-devel] [PATCH v2] pc: Don't make die-id mandatory unless necessary

2019-08-26 Thread Igor Mammedov
On Fri, 16 Aug 2019 14:07:50 -0300 Eduardo Habkost wrote: > We have this issue reported when using libvirt to hotplug CPUs: > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 > > Basically, libvirt is not copying die-id from > query-hotpluggable-cpus, but die-id is now mandatory. > > We

[Qemu-devel] [PATCH v2] pc: Don't make die-id mandatory unless necessary

2019-08-16 Thread Eduardo Habkost
We have this issue reported when using libvirt to hotplug CPUs: https://bugzilla.redhat.com/show_bug.cgi?id=1741451 Basically, libvirt is not copying die-id from query-hotpluggable-cpus, but die-id is now mandatory. We could blame libvirt and say it is not following the documented interface,