Re: [Qemu-devel] [PATCH v2] qcow2: Add bdrv_discard support

2014-08-27 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 12:38:06AM +0800, Jun Li wrote: > Why bdrv_discard does not yet pass the discard on to the underlying file > system driver? And this exist a potential issue: host cluster leak for > qcow2. As qcow2 image can be created on RAW disk, > so this is not just "does not yet pass th

Re: [Qemu-devel] [PATCH v2] qcow2: Add bdrv_discard support

2014-08-24 Thread Jun Li
Hi Kevin and Stefan, As the realize of bdrv_discard, and this patch has been received, but I have some question. This adds a bdrv_discard function to qcow2 that frees the discarded clusters. It does not yet pass the discard on to the underlying file system driver, but the space can be reused

Re: [Qemu-devel] [PATCH v2] qcow2: Add bdrv_discard support

2011-01-28 Thread Stefan Hajnoczi
On Fri, Jan 28, 2011 at 11:41 AM, Kevin Wolf wrote: > This adds a bdrv_discard function to qcow2 that frees the discarded clusters. > It does not yet pass the discard on to the underlying file system driver, but > the space can be reused by future writes to the image. > > Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH v2] qcow2: Add bdrv_discard support

2011-01-28 Thread Kevin Wolf
This adds a bdrv_discard function to qcow2 that frees the discarded clusters. It does not yet pass the discard on to the underlying file system driver, but the space can be reused by future writes to the image. Signed-off-by: Kevin Wolf --- v2: - Added offset > end_offset check block/qcow2-clu