Re: [Qemu-devel] [PATCH v2] qcow2: add overlap check for bitmap directory

2018-06-25 Thread Max Reitz
On 2018-03-19 09:07, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > If it appropriate for 2.12, let's push it. If not - then for 2.13. > > > v2: - squash 02 (indentation fix) to 01 > - drop comment from qcow2_check_metadata_overlap() > - set

Re: [Qemu-devel] [PATCH v2] qcow2: add overlap check for bitmap directory

2018-06-04 Thread John Snow
On 06/04/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote: > 20.04.2018 15:12, Vladimir Sementsov-Ogievskiy wrote: >> 19.04.2018 23:57, John Snow wrote: >>> >>> On 03/19/2018 04:07 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- If it

Re: [Qemu-devel] [PATCH v2] qcow2: add overlap check for bitmap directory

2018-06-04 Thread Vladimir Sementsov-Ogievskiy
20.04.2018 15:12, Vladimir Sementsov-Ogievskiy wrote: 19.04.2018 23:57, John Snow wrote: On 03/19/2018 04:07 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- If it appropriate for 2.12, let's push it. If not - then for 2.13. I wonder if I can make the

Re: [Qemu-devel] [PATCH v2] qcow2: add overlap check for bitmap directory

2018-04-20 Thread Vladimir Sementsov-Ogievskiy
19.04.2018 23:57, John Snow wrote: On 03/19/2018 04:07 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- If it appropriate for 2.12, let's push it. If not - then for 2.13. I wonder if I can make the case that this should be in 2.12.1; arguably it is imp

Re: [Qemu-devel] [PATCH v2] qcow2: add overlap check for bitmap directory

2018-04-19 Thread John Snow
On 03/19/2018 04:07 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > If it appropriate for 2.12, let's push it. If not - then for 2.13. > I wonder if I can make the case that this should be in 2.12.1; arguably it is important to prevent corruptio

[Qemu-devel] [PATCH v2] qcow2: add overlap check for bitmap directory

2018-03-19 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- If it appropriate for 2.12, let's push it. If not - then for 2.13. v2: - squash 02 (indentation fix) to 01 - drop comment from qcow2_check_metadata_overlap() - set @ign to QCOW2_OL_BITMAP_DIRECTORY for in-place case in bitmap_list_st