[Qemu-devel] [PATCH v2] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-03 Thread Michael Roth
When CHR_EVENT_OPEN was initially added, it was CHR_EVENT_RESET, and it was issued as a bottom-half: 86e94dea5b740dad65446c857f6959eae43e0ba6 Which we basically used to print out a greeting/prompt for the monitor. AFAICT the only reason this was ever done in a BH was because in some cases we'd m

Re: [Qemu-devel] [PATCH v2] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-03 Thread mdroth
On Mon, Jun 03, 2013 at 12:17:00PM -0500, Anthony Liguori wrote: > Michael Roth writes: > > > When CHR_EVENT_OPEN was initially added, it was CHR_EVENT_RESET, > > and it was issued as a bottom-half: > > > > 86e94dea5b740dad65446c857f6959eae43e0ba6 > > > > Which we basically used to print out a gr

Re: [Qemu-devel] [PATCH v2] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-03 Thread Anthony Liguori
Michael Roth writes: > When CHR_EVENT_OPEN was initially added, it was CHR_EVENT_RESET, > and it was issued as a bottom-half: > > 86e94dea5b740dad65446c857f6959eae43e0ba6 > > Which we basically used to print out a greeting/prompt for the > monitor. > > AFAICT the only reason this was ever done in