Re: [Qemu-devel] [PATCH v2] qemu-img: let 'qemu-img convert' flush data

2012-04-13 Thread Kevin Wolf
Am 13.04.2012 04:18, schrieb Liu Yuan: > On 04/11/2012 11:21 PM, Liu Yuan wrote: > >> On 04/11/2012 11:01 PM, Paolo Bonzini wrote: >> >>> bdrv_delete already does this. >>> >>> Paolo >> >> >> Ah yes. Thanks pointing out. >> > > > Hi Kevin, >If no further comment, would you pick up following

Re: [Qemu-devel] [PATCH v2] qemu-img: let 'qemu-img convert' flush data

2012-04-12 Thread Liu Yuan
On 04/11/2012 11:21 PM, Liu Yuan wrote: > On 04/11/2012 11:01 PM, Paolo Bonzini wrote: > >> bdrv_delete already does this. >> >> Paolo > > > Ah yes. Thanks pointing out. > Hi Kevin, If no further comment, would you pick up following patch? Yuan > From 459414f677f6449482f9cfcb7917ff0e242

Re: [Qemu-devel] [PATCH v2] qemu-img: let 'qemu-img convert' flush data

2012-04-11 Thread Liu Yuan
On 04/11/2012 11:01 PM, Paolo Bonzini wrote: > bdrv_delete already does this. > > Paolo Ah yes. Thanks pointing out. >From 459414f677f6449482f9cfcb7917ff0e242ad490 Mon Sep 17 00:00:00 2001 From: Liu Yuan Date: Wed, 11 Apr 2012 23:19:54 +0800 Subject: [PATCH v3] qemu-img: let 'qemu-img convert

Re: [Qemu-devel] [PATCH v2] qemu-img: let 'qemu-img convert' flush data

2012-04-11 Thread Paolo Bonzini
Il 11/04/2012 16:46, Liu Yuan ha scritto: > From: Liu Yuan > > The 'qemu-img convert -h' advertise that the default cache mode is > 'writeback', while in fact it is 'unsafe'. > > This patch 1) fix the help manual and 2) let bdrv_close() call bdrv_flush() > 3) explicitly calls bdrv_close() to flu

[Qemu-devel] [PATCH v2] qemu-img: let 'qemu-img convert' flush data

2012-04-11 Thread Liu Yuan
From: Liu Yuan The 'qemu-img convert -h' advertise that the default cache mode is 'writeback', while in fact it is 'unsafe'. This patch 1) fix the help manual and 2) let bdrv_close() call bdrv_flush() 3) explicitly calls bdrv_close() to flush the dirty bits. 3) is needed because some backend st