Re: [Qemu-devel] [PATCH v2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-28 Thread Alon Levy
On Sat, Jul 28, 2012 at 09:01:11AM +, Blue Swirl wrote: > > +// - this is not a guest io, but a reply, so async_io isn't > > set. > > Please use checkpatch.pl to avoid C99 comments. > Doh, I must have missed it (I do), will fix, thanks. Alon

Re: [Qemu-devel] [PATCH v2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-28 Thread Blue Swirl
On Sat, Jul 28, 2012 at 8:56 AM, Alon Levy wrote: > bumps spice-protocol to 0.12.0 for new IO. > revision bumped to 4 for new IO support, enabled for spice-server >= 0.11.1 > on migration reissue spice_qxl_monitors_config_async. > > RHBZ: 770842 > > Signed-off-by: Alon Levy > --- > configure

[Qemu-devel] [PATCH v2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-28 Thread Alon Levy
bumps spice-protocol to 0.12.0 for new IO. revision bumped to 4 for new IO support, enabled for spice-server >= 0.11.1 on migration reissue spice_qxl_monitors_config_async. RHBZ: 770842 Signed-off-by: Alon Levy --- configure |2 +- hw/qxl.c | 47

Re: [Qemu-devel] [PATCH v2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-25 Thread Yonit Halperin
Hi, On 07/25/2012 08:29 PM, Alon Levy wrote: On Wed, Jul 25, 2012 at 12:00:21PM +0300, Yonit Halperin wrote: Hi, I think you should save the monitor configuration as part of the vmstate, and recall spice_qxl_monitors_config_async in qxl_post_load. Good point, will do. Would be nice if I could

Re: [Qemu-devel] [PATCH v2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-25 Thread Alon Levy
On Wed, Jul 25, 2012 at 12:00:21PM +0300, Yonit Halperin wrote: > Hi, > I think you should save the monitor configuration as part of the vmstate, > and recall spice_qxl_monitors_config_async in qxl_post_load. Good point, will do. Would be nice if I could differentiate same client (that doesn't nee

Re: [Qemu-devel] [PATCH v2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-25 Thread Yonit Halperin
Hi, I think you should save the monitor configuration as part of the vmstate, and recall spice_qxl_monitors_config_async in qxl_post_load. Regards, Yonit. On 07/23/2012 07:33 PM, Alon Levy wrote: bumps spice-protocol to 0.12.0 for new IO. revision bumped to 4 for new IO support, enabled for s

[Qemu-devel] [PATCH v2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-23 Thread Alon Levy
bumps spice-protocol to 0.12.0 for new IO. revision bumped to 4 for new IO support, enabled for spice-server >= 0.11.1 RHBZ: 770842 Signed-off-by: Alon Levy --- v2: fixed interface_async_complete_io to not complain about unexpected async io. configure|2 +- hw/qxl.c | 30