Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-14 Thread Paolo Bonzini
On 10/14/2011 04:24 PM, Luiz Capitulino wrote: Yes, you're right. But there's another problem there: the VM is stopped when the migration process finishes. So, if you migrate again, there won't be a POST_MIGRATE -> FINISH_MIGRATE transition, as vm_stop() will just return. Acked-by: Paolo Bonzi

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-14 Thread Luiz Capitulino
On Fri, 14 Oct 2011 15:37:29 +0200 Paolo Bonzini wrote: > On 10/14/2011 03:23 PM, Luiz Capitulino wrote: > > I'm not, because I'm assuming that allowing a transition from 'paused' to > > 'postmigrate' plus this fix: > > > > http://lists.gnu.org/archive/html/qemu-devel/2011-10/msg01430.html > >

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-14 Thread Paolo Bonzini
On 10/14/2011 03:23 PM, Luiz Capitulino wrote: I'm not, because I'm assuming that allowing a transition from 'paused' to 'postmigrate' plus this fix: http://lists.gnu.org/archive/html/qemu-devel/2011-10/msg01430.html I think POST_MIGRATE -> FINISH_MIGRATE should be still allowed in case you

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-14 Thread Luiz Capitulino
On Fri, 14 Oct 2011 08:56:57 +0200 Paolo Bonzini wrote: > On 10/13/2011 10:26 PM, Luiz Capitulino wrote: > > I'm going to take my word back on this one, I've found the real cause of the > > problem. Will post the patch right now. > > > > Are you keeping the vl.c hunks though? I'm not, because I

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-13 Thread Paolo Bonzini
On 10/13/2011 10:26 PM, Luiz Capitulino wrote: I'm going to take my word back on this one, I've found the real cause of the problem. Will post the patch right now. Are you keeping the vl.c hunks though? Paolo

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-13 Thread Luiz Capitulino
On Tue, 11 Oct 2011 14:52:48 -0300 Luiz Capitulino wrote: > On Tue, 11 Oct 2011 09:22:42 +0200 > Paolo Bonzini wrote: > > > This patch adds more valid transitions to the table, and avoids > > that the VM remains stuck in RSTATE_SAVEVM state when savevm is > > done on a paused virtual machine. >

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-11 Thread Luiz Capitulino
On Tue, 11 Oct 2011 09:22:42 +0200 Paolo Bonzini wrote: > This patch adds more valid transitions to the table, and avoids > that the VM remains stuck in RSTATE_SAVEVM state when savevm is > done on a paused virtual machine. > > Signed-off-by: Paolo Bonzini Applied to the qmp branch, thanks. >

[Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-11 Thread Paolo Bonzini
This patch adds more valid transitions to the table, and avoids that the VM remains stuck in RSTATE_SAVEVM state when savevm is done on a paused virtual machine. Signed-off-by: Paolo Bonzini --- savevm.c |9 +++-- vl.c |5 + 2 files changed, 12 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-10 Thread Luiz Capitulino
On Tue, 4 Oct 2011 15:15:40 +0200 Paolo Bonzini wrote: > This patch adds more valid transitions to the table, and avoids > that the VM remains stuck in RSTATE_SAVEVM state when savevm is > done on a paused virtual machine. > > Signed-off-by: Paolo Bonzini Looks good, but it needs to be rebase

[Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-04 Thread Paolo Bonzini
This patch adds more valid transitions to the table, and avoids that the VM remains stuck in RSTATE_SAVEVM state when savevm is done on a paused virtual machine. Signed-off-by: Paolo Bonzini --- savevm.c |9 +++-- vl.c |5 + 2 files changed, 12 insertions(+), 2 deletions(-)