On 2015/2/12 0:50, Gerd Hoffmann wrote:
> Found by coverity.
>
> Signed-off-by: Gerd Hoffmann
> Reviewed-by: Paolo Bonzini
> ---
> monitor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/monitor.c b/monitor.c
> index c3cc060..2c37953 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -
Found by coverity.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Paolo Bonzini
---
monitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/monitor.c b/monitor.c
index c3cc060..2c37953 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1101,6 +1101,7 @@ static int client_migrate_info(Monitor *mon, con
On Mo, 2014-12-08 at 10:31 +0100, Stefan Weil wrote:
> Am 08.12.2014 um 10:25 schrieb Gerd Hoffmann:
> > On Fr, 2014-12-05 at 16:30 +0800, arei.gong...@huawei.com wrote:
> >> From: Gonglei
> >>
> >> If errors happen for middle items of channel_list,
> >> qmp_query_spice_channels() returns NULL, an
Am 08.12.2014 um 10:25 schrieb Gerd Hoffmann:
> On Fr, 2014-12-05 at 16:30 +0800, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> If errors happen for middle items of channel_list,
>> qmp_query_spice_channels() returns NULL, and the variable
>> cur_item going out of scope leaks the storage i
On Fr, 2014-12-05 at 16:30 +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> If errors happen for middle items of channel_list,
> qmp_query_spice_channels() returns NULL, and the variable
> cur_item going out of scope leaks the storage it points to.
>
> The flag is a compatibility thing
On 2014/12/5 20:56, Eric Blake wrote:
> On 12/05/2014 01:30 AM, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> If errors happen for middle items of channel_list,
>> qmp_query_spice_channels() returns NULL, and the variable
>> cur_item going out of scope leaks the storage it points to.
>>
>
On 12/05/2014 01:30 AM, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> If errors happen for middle items of channel_list,
> qmp_query_spice_channels() returns NULL, and the variable
> cur_item going out of scope leaks the storage it points to.
>
> The flag is a compatibility thing for older
From: Gonglei
If errors happen for middle items of channel_list,
qmp_query_spice_channels() returns NULL, and the variable
cur_item going out of scope leaks the storage it points to.
The flag is a compatibility thing for older spice-server
versions. Meanwhile our minimum spice version requiremen
