Re: [Qemu-devel] [PATCH v2] tcg: Remove stack protection from helper functions

2011-09-26 Thread Peter Maydell
On 26 September 2011 19:20, Blue Swirl wrote: > It would be interesting to have some benchmarks. I'd expect that most > of the run time is spent within generated code, the next largest item > should be the translator and any helpers should be marginal. Depends a lot on the target, I suspect. On A

Re: [Qemu-devel] [PATCH v2] tcg: Remove stack protection from helper functions

2011-09-26 Thread Blue Swirl
On Mon, Sep 26, 2011 at 6:25 PM, Jan Kiszka wrote: > On 2011-09-26 20:20, Blue Swirl wrote: >> On Mon, Sep 26, 2011 at 5:33 PM, Jan Kiszka wrote: >>> On 2011-09-26 19:22, Blue Swirl wrote: On Mon, Sep 26, 2011 at 11:56 AM, Peter Maydell wrote: > On 26 September 2011 12:43, Jan Kisz

Re: [Qemu-devel] [PATCH v2] tcg: Remove stack protection from helper functions

2011-09-26 Thread Jan Kiszka
On 2011-09-26 20:20, Blue Swirl wrote: > On Mon, Sep 26, 2011 at 5:33 PM, Jan Kiszka wrote: >> On 2011-09-26 19:22, Blue Swirl wrote: >>> On Mon, Sep 26, 2011 at 11:56 AM, Peter Maydell >>> wrote: On 26 September 2011 12:43, Jan Kiszka wrote: > On 2011-09-26 13:33, Peter Maydell wrote:

Re: [Qemu-devel] [PATCH v2] tcg: Remove stack protection from helper functions

2011-09-26 Thread Blue Swirl
On Mon, Sep 26, 2011 at 5:33 PM, Jan Kiszka wrote: > On 2011-09-26 19:22, Blue Swirl wrote: >> On Mon, Sep 26, 2011 at 11:56 AM, Peter Maydell >> wrote: >>> On 26 September 2011 12:43, Jan Kiszka wrote: On 2011-09-26 13:33, Peter Maydell wrote: > On 26 September 2011 11:51, Jan Kiszka

Re: [Qemu-devel] [PATCH v2] tcg: Remove stack protection from helper functions

2011-09-26 Thread Jan Kiszka
On 2011-09-26 19:22, Blue Swirl wrote: > On Mon, Sep 26, 2011 at 11:56 AM, Peter Maydell > wrote: >> On 26 September 2011 12:43, Jan Kiszka wrote: >>> On 2011-09-26 13:33, Peter Maydell wrote: On 26 September 2011 11:51, Jan Kiszka wrote: > This increases the overhead of frequently exec

Re: [Qemu-devel] [PATCH v2] tcg: Remove stack protection from helper functions

2011-09-26 Thread Blue Swirl
On Mon, Sep 26, 2011 at 11:56 AM, Peter Maydell wrote: > On 26 September 2011 12:43, Jan Kiszka wrote: >> On 2011-09-26 13:33, Peter Maydell wrote: >>> On 26 September 2011 11:51, Jan Kiszka wrote: This increases the overhead of frequently executed helpers. We need to move rule past QE

Re: [Qemu-devel] [PATCH v2] tcg: Remove stack protection from helper functions

2011-09-26 Thread Peter Maydell
On 26 September 2011 12:43, Jan Kiszka wrote: > On 2011-09-26 13:33, Peter Maydell wrote: >> On 26 September 2011 11:51, Jan Kiszka wrote: >>> This increases the overhead of frequently executed helpers. We need to >>> move rule past QEMU_CFLAGS assignment to ensure that the required simple >>> as

Re: [Qemu-devel] [PATCH v2] tcg: Remove stack protection from helper functions

2011-09-26 Thread Jan Kiszka
On 2011-09-26 13:33, Peter Maydell wrote: > On 26 September 2011 11:51, Jan Kiszka wrote: >> This increases the overhead of frequently executed helpers. We need to >> move rule past QEMU_CFLAGS assignment to ensure that the required simple >> assignment picks up all bits. The signal workaround is

Re: [Qemu-devel] [PATCH v2] tcg: Remove stack protection from helper functions

2011-09-26 Thread Peter Maydell
On 26 September 2011 11:51, Jan Kiszka wrote: > This increases the overhead of frequently executed helpers. We need to > move rule past QEMU_CFLAGS assignment to ensure that the required simple > assignment picks up all bits. The signal workaround is moved just for > the sake of consistency. > +#

[Qemu-devel] [PATCH v2] tcg: Remove stack protection from helper functions

2011-09-26 Thread Jan Kiszka
This increases the overhead of frequently executed helpers. We need to move rule past QEMU_CFLAGS assignment to ensure that the required simple assignment picks up all bits. The signal workaround is moved just for the sake of consistency. Signed-off-by: Jan Kiszka --- Changes in v2: - unbreak q