Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-22 Thread Jay Foad
>> Does it build if you remove line 1696? If so, I'd suggest doing that. >> > > Yes, that fixes it. Please grep through all tcg targets and send a patch > removing all references to ld32s if you think it's not necessary. Done. Unfortunately I'm not in a position to try building any of the affected

Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-22 Thread Alexander Graf
Jay Foad wrote: >> This patch breaks building on ppc32. Reverting it makes it compile again: >> > > >> /suse/agraf/git/qemu/tcg/ppc/tcg-target.c:1696: error: >> ‘INDEX_op_qemu_ld32s’ undeclared here (not in a function) >> > > Does it build if you remove line 1696? If so, I'd suggest do

Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-22 Thread Stefan Weil
Jay Foad schrieb: >> This patch breaks building on ppc32. Reverting it makes it compile again: >> > > >> /suse/agraf/git/qemu/tcg/ppc/tcg-target.c:1696: error: >> ‘INDEX_op_qemu_ld32s’ undeclared here (not in a function) >> > > Does it build if you remove line 1696? If so, I'd suggest

Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-22 Thread Jay Foad
> This patch breaks building on ppc32. Reverting it makes it compile again: > /suse/agraf/git/qemu/tcg/ppc/tcg-target.c:1696: error: > ‘INDEX_op_qemu_ld32s’ undeclared here (not in a function) Does it build if you remove line 1696? If so, I'd suggest doing that. Thanks, Jay.

Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-22 Thread Alexander Graf
Blue Swirl wrote: > Thanks, applied. > This patch breaks building on ppc32. Reverting it makes it compile again: In file included from /suse/agraf/git/qemu/tcg/tcg.c:158: /suse/agraf/git/qemu/tcg/ppc/tcg-target.c:1696: error: ‘INDEX_op_qemu_ld32s’ undeclared here (not in a function) Alex >

Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-20 Thread Blue Swirl
Thanks, applied. On 2/20/10, Jay Foad wrote: > On 32-bit hosts op_qemu_ld32s is unused. Remove it to fix the > following assertion failure: > > qemu-alpha: tcg/tcg.c:1055: > tcg_add_target_add_op_defs: Assertion `tcg_op_defs[op].used' failed. > > Signed-off-by: Jay Foad > --- > tcg/tcg-op

[Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-20 Thread Jay Foad
On 32-bit hosts op_qemu_ld32s is unused. Remove it to fix the following assertion failure: qemu-alpha: tcg/tcg.c:1055: tcg_add_target_add_op_defs: Assertion `tcg_op_defs[op].used' failed. Signed-off-by: Jay Foad --- tcg/tcg-opc.h |5 - 1 files changed, 0 insertions(+), 5 deletions(-) d