Re: [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-21 Thread Michael S. Tsirkin
On Tue, Nov 21, 2017 at 05:58:12PM +0100, Igor Mammedov wrote: > anyways, if you prefer having mixed endianness here, I won't mind much, > as impact of test case is much smaller so we'll see down the road > if it became any better. I agree here. > (as far as we continue going in direction > of us

Re: [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-21 Thread Igor Mammedov
On Tue, 21 Nov 2017 18:31:19 +0200 "Michael S. Tsirkin" wrote: > On Tue, Nov 21, 2017 at 05:22:36PM +0100, Igor Mammedov wrote: > > > > > > > > probably it's been discussed but, why not do > > > > > > > > leXX_to_cpu() > > > > > > > > here, instead of making each place that access read field > >

Re: [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-21 Thread Michael S. Tsirkin
On Tue, Nov 21, 2017 at 05:22:36PM +0100, Igor Mammedov wrote: > > > > > > > probably it's been discussed but, why not do > > > > > > > leXX_to_cpu() > > > > > > > here, instead of making each place that access read field > > > > > > > to do leXX_to_cpu() manually.? > > > > > > > > > > > > > > Be

Re: [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-21 Thread Igor Mammedov
On Tue, 21 Nov 2017 18:02:48 +0200 "Michael S. Tsirkin" wrote: > On Tue, Nov 21, 2017 at 04:58:09PM +0100, Igor Mammedov wrote: > > On Tue, 21 Nov 2017 16:47:11 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Nov 21, 2017 at 02:26:39PM +0100, Igor Mammedov wrote: > > > > On Mon, 20

Re: [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-21 Thread Michael S. Tsirkin
On Tue, Nov 21, 2017 at 04:58:09PM +0100, Igor Mammedov wrote: > On Tue, 21 Nov 2017 16:47:11 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Nov 21, 2017 at 02:26:39PM +0100, Igor Mammedov wrote: > > > On Mon, 20 Nov 2017 22:32:29 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Mo

Re: [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-21 Thread Igor Mammedov
On Tue, 21 Nov 2017 16:47:11 +0200 "Michael S. Tsirkin" wrote: > On Tue, Nov 21, 2017 at 02:26:39PM +0100, Igor Mammedov wrote: > > On Mon, 20 Nov 2017 22:32:29 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Nov 20, 2017 at 05:55:22PM +0100, Igor Mammedov wrote: > > > > On Thu, 16

Re: [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-21 Thread Michael S. Tsirkin
On Tue, Nov 21, 2017 at 02:26:39PM +0100, Igor Mammedov wrote: > On Mon, 20 Nov 2017 22:32:29 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 20, 2017 at 05:55:22PM +0100, Igor Mammedov wrote: > > > On Thu, 16 Nov 2017 13:17:02 +0100 > > > Thomas Huth wrote: > > > > > > > The bios-table

Re: [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-21 Thread Igor Mammedov
On Mon, 20 Nov 2017 22:32:29 +0200 "Michael S. Tsirkin" wrote: > On Mon, Nov 20, 2017 at 05:55:22PM +0100, Igor Mammedov wrote: > > On Thu, 16 Nov 2017 13:17:02 +0100 > > Thomas Huth wrote: > > > > > The bios-tables-test was writing out files that we pass to iasl in > > > with the wrong endia

Re: [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-20 Thread Michael S. Tsirkin
On Mon, Nov 20, 2017 at 05:55:22PM +0100, Igor Mammedov wrote: > On Thu, 16 Nov 2017 13:17:02 +0100 > Thomas Huth wrote: > > > The bios-tables-test was writing out files that we pass to iasl in > > with the wrong endianness in the header when running on a big endian > > host. So instead of storin

Re: [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-20 Thread Thomas Huth
On 20.11.2017 17:55, Igor Mammedov wrote: > On Thu, 16 Nov 2017 13:17:02 +0100 > Thomas Huth wrote: > >> The bios-tables-test was writing out files that we pass to iasl in >> with the wrong endianness in the header when running on a big endian >> host. So instead of storing mixed endian informati

Re: [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-20 Thread Igor Mammedov
On Thu, 16 Nov 2017 13:17:02 +0100 Thomas Huth wrote: > The bios-tables-test was writing out files that we pass to iasl in > with the wrong endianness in the header when running on a big endian > host. So instead of storing mixed endian information in our structures, > let's keep everything in li

[Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-16 Thread Thomas Huth
The bios-tables-test was writing out files that we pass to iasl in with the wrong endianness in the header when running on a big endian host. So instead of storing mixed endian information in our structures, let's keep everything in little endian and byte-swap it only when we need a value in the co