Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing

2017-05-23 Thread Michael Roth
Quoting Thomas Huth (2017-05-23 02:25:30) > On 22.05.2017 17:58, no-re...@patchew.org wrote: > > This series failed automatic build test. Please find the testing commands > > and > > their output below. If you have docker installed, you can probably > > reproduce it > > locally. > [...] > >

Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing

2017-05-23 Thread John Snow
On 05/23/2017 03:25 AM, Thomas Huth wrote: > On 22.05.2017 17:58, no-re...@patchew.org wrote: >> This series failed automatic build test. Please find the testing commands and >> their output below. If you have docker installed, you can probably reproduce >> it >> locally. > [...] >> LEX co

Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing

2017-05-23 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing

2017-05-23 Thread Samuel Thibault
Thomas Huth, on mar. 23 mai 2017 09:25:30 +0200, wrote: > > /tmp/qemu-test/src/slirp/tcp_input.c: In function ‘tcp_input’: > > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_p’ may be > > used uninitialized in this function > > I've never seen these warnings in tcp_input.c before

Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing

2017-05-23 Thread Thomas Huth
On 22.05.2017 17:58, no-re...@patchew.org wrote: > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. [...] >LEX convert-dtsv0-lexer.lex.c >DEP /tmp/qemu-test/s

Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing

2017-05-22 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing

[Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing

2017-05-22 Thread Thomas Huth
When you currently try to run a test directly from the command line without setting the QTEST_QEMU_BINARY environment variable first, you are presented with an unhelpful assertion message like this: ERROR:tests/libqtest.c:163:qtest_init_without_qmp_handshake: assertion failed: (qemu_binary != NU