Re: [Qemu-devel] [PATCH v2] timer: a9gtimer: check auto-increment register value

2016-10-03 Thread P J P
Hello Peter, +-- On Sun, 2 Oct 2016, Peter Maydell wrote --+ | The timer can't autoincrement by more than a 32 bit value, but | the timer value is 64 bits, and since this code may be doing more than | one autoincrement it's better to use 64 bits. Okay. | If in doubt, you need to check the da

Re: [Qemu-devel] [PATCH v2] timer: a9gtimer: check auto-increment register value

2016-10-02 Thread Peter Maydell
On 1 October 2016 at 23:15, P J P wrote: > Hello Peter, > > +-- On Fri, 30 Sep 2016, Peter Maydell wrote --+ > | Since the gtb->compare field is 64 bit your inc variable should > | probably be uint64_t. > > Okay. I was wondering about its values, as gtb->inc is 'uint32_t' type. The timer can

Re: [Qemu-devel] [PATCH v2] timer: a9gtimer: check auto-increment register value

2016-10-01 Thread P J P
Hello Peter, +-- On Fri, 30 Sep 2016, Peter Maydell wrote --+ | > -int i; | > +uint32_t i, inc; | | Why have you changed the type of i when you haven't changed | any of the code that works with it? Actually I declared 'inc' on the same line, then changed type to 'uint32' as 'gtb->in

Re: [Qemu-devel] [PATCH v2] timer: a9gtimer: check auto-increment register value

2016-09-30 Thread Peter Maydell
On 28 September 2016 at 02:16, P J P wrote: > From: Prasad J Pandit > > ARM A9MP processor has a peripheral timer with an auto-increment > register, which holds an increment step value. A user could set > this value to zero, when auto-increment control bit is enabled. > This leads to an infinite

[Qemu-devel] [PATCH v2] timer: a9gtimer: check auto-increment register value

2016-09-28 Thread P J P
From: Prasad J Pandit ARM A9MP processor has a peripheral timer with an auto-increment register, which holds an increment step value. A user could set this value to zero, when auto-increment control bit is enabled. This leads to an infinite loop in 'a9_gtimer_update' while updating comparator val