Re: [Qemu-devel] [PATCH v2] ui/console: Precautionary glBindTexture and surface->texture validation in surface_gl_update_texture

2019-05-07 Thread Marcel Apfelbaum
On 5/7/19 9:49 AM, Hou Qiming wrote: My real name is "HOU Qiming". @Marcel Apfelbaum can you incorporate that in your v2 patch? Thanks! Sure thing, Thanks, Marcel Qiming On Tue, May 7, 2019 at 2:25 PM Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v2] ui/console: Precautionary glBindTexture and surface->texture validation in surface_gl_update_texture

2019-05-07 Thread Philippe Mathieu-Daudé
On 5/7/19 8:49 AM, Hou Qiming wrote: > My real name is "HOU Qiming". @Marcel Apfelbaum > can you incorporate that in your v2 > patch? Thanks! Thanks a lot Qiming :) > On Tue, May 7, 2019 at 2:25 PM Philippe Mathieu-Daudé > wrote: >

Re: [Qemu-devel] [PATCH v2] ui/console: Precautionary glBindTexture and surface->texture validation in surface_gl_update_texture

2019-05-07 Thread Hou Qiming
My real name is "HOU Qiming". @Marcel Apfelbaum can you incorporate that in your v2 patch? Thanks! Qiming On Tue, May 7, 2019 at 2:25 PM Philippe Mathieu-Daudé wrote: > Hi Marcel, > > On 5/7/19 7:49 AM, Marcel Apfelbaum wrote: > > From: HQM > > > > In a GVT-g setup with dmabuf and GTK GUI,

Re: [Qemu-devel] [PATCH v2] ui/console: Precautionary glBindTexture and surface->texture validation in surface_gl_update_texture

2019-05-07 Thread Philippe Mathieu-Daudé
Hi Marcel, On 5/7/19 7:49 AM, Marcel Apfelbaum wrote: > From: HQM > > In a GVT-g setup with dmabuf and GTK GUI, the current 2D texture at > surface_gl_update_texture is not necessarily > surface->texture. Adding a glBindTexture fixes related crashes and > artifacts, and is generally more

[Qemu-devel] [PATCH v2] ui/console: Precautionary glBindTexture and surface->texture validation in surface_gl_update_texture

2019-05-06 Thread Marcel Apfelbaum
From: HQM In a GVT-g setup with dmabuf and GTK GUI, the current 2D texture at surface_gl_update_texture is not necessarily surface->texture. Adding a glBindTexture fixes related crashes and artifacts, and is generally more secure. Signed-off-by: HQM Tested-by: Marcel Apfelbaum [fixed malformed