Re: [Qemu-devel] [PATCH v2] usb-storage: Fix share-rw option parsing

2018-01-25 Thread Gerd Hoffmann
On Wed, Jan 17, 2018 at 08:52:22AM +0800, Fam Zheng wrote: > Because usb-storage creates an internal scsi device, we should propagate > options. We already do so for bootindex etc, but failed to take care of > share-rw. Fix it in an apparent way: add a new parameter to > scsi_bus_legacy_add_drive a

Re: [Qemu-devel] [PATCH v2] usb-storage: Fix share-rw option parsing

2018-01-17 Thread Darren Kenny
The code changes look good. Reviewed-by: Darren Kenny Thanks, Darren. On Wed, Jan 17, 2018 at 08:52:22AM +0800, Fam Zheng wrote: Because usb-storage creates an internal scsi device, we should propagate options. We already do so for bootindex etc, but failed to take care of share-rw. Fix it

[Qemu-devel] [PATCH v2] usb-storage: Fix share-rw option parsing

2018-01-16 Thread Fam Zheng
Because usb-storage creates an internal scsi device, we should propagate options. We already do so for bootindex etc, but failed to take care of share-rw. Fix it in an apparent way: add a new parameter to scsi_bus_legacy_add_drive and pass in s->conf.share_rw. Cc: qemu-sta...@nongnu.org Signed-off