Re: [Qemu-devel] [PATCH v2] vhost-user: don't poke at chardev internal QemuOpts

2016-10-07 Thread Daniel P. Berrange
On Fri, Oct 07, 2016 at 10:12:23AM +, Marc-André Lureau wrote: > Hi > > On Fri, Oct 7, 2016 at 1:50 PM Daniel P. Berrange > wrote: > > > The vhost-user code is poking at the QemuOpts instance > > in the CharDriverState struct, not realizing that it is > > valid for this to be NULL. e.g. the

Re: [Qemu-devel] [PATCH v2] vhost-user: don't poke at chardev internal QemuOpts

2016-10-07 Thread Daniel P. Berrange
On Fri, Oct 07, 2016 at 10:59:09AM +0100, Peter Maydell wrote: > On 7 October 2016 at 10:49, Daniel P. Berrange wrote: > > The vhost-user code is poking at the QemuOpts instance > > in the CharDriverState struct, not realizing that it is > > valid for this to be NULL. e.g. the following crash > >

Re: [Qemu-devel] [PATCH v2] vhost-user: don't poke at chardev internal QemuOpts

2016-10-07 Thread Marc-André Lureau
Hi On Fri, Oct 7, 2016 at 1:50 PM Daniel P. Berrange wrote: > The vhost-user code is poking at the QemuOpts instance > in the CharDriverState struct, not realizing that it is > valid for this to be NULL. e.g. the following crash > shows a codepath where it will be NULL: > > Program terminated w

Re: [Qemu-devel] [PATCH v2] vhost-user: don't poke at chardev internal QemuOpts

2016-10-07 Thread Peter Maydell
On 7 October 2016 at 10:49, Daniel P. Berrange wrote: > The vhost-user code is poking at the QemuOpts instance > in the CharDriverState struct, not realizing that it is > valid for this to be NULL. e.g. the following crash > shows a codepath where it will be NULL: > +typedef enum { > +/* Whet

[Qemu-devel] [PATCH v2] vhost-user: don't poke at chardev internal QemuOpts

2016-10-07 Thread Daniel P. Berrange
The vhost-user code is poking at the QemuOpts instance in the CharDriverState struct, not realizing that it is valid for this to be NULL. e.g. the following crash shows a codepath where it will be NULL: Program terminated with signal SIGSEGV, Segmentation fault. #0 0x55baf6ab4adc in qemu_op