Re: [Qemu-devel] [PATCH v2] xics_kvm: fix a build break

2018-06-12 Thread David Gibson
On Tue, Jun 12, 2018 at 12:11:35PM +0200, Cédric Le Goater wrote: > On CentOS 7.5, gcc-4.8.5-28.el7_5.1.ppc64le fails to build QEMU due to : > > hw/intc/xics_kvm.c: In function ‘ics_set_kvm_state’: > hw/intc/xics_kvm.c:281:13: error: ‘ret’ may be used uninitialized in this > function [-Wer

Re: [Qemu-devel] [PATCH v2] xics_kvm: fix a build break

2018-06-12 Thread Cédric Le Goater
On 06/12/2018 01:41 PM, Greg Kurz wrote: > On Tue, 12 Jun 2018 12:11:35 +0200 > Cédric Le Goater wrote: > >> On CentOS 7.5, gcc-4.8.5-28.el7_5.1.ppc64le fails to build QEMU due to : >> >> hw/intc/xics_kvm.c: In function ‘ics_set_kvm_state’: >> hw/intc/xics_kvm.c:281:13: error: ‘ret’ may be us

Re: [Qemu-devel] [PATCH v2] xics_kvm: fix a build break

2018-06-12 Thread Greg Kurz
On Tue, 12 Jun 2018 12:11:35 +0200 Cédric Le Goater wrote: > On CentOS 7.5, gcc-4.8.5-28.el7_5.1.ppc64le fails to build QEMU due to : > > hw/intc/xics_kvm.c: In function ‘ics_set_kvm_state’: > hw/intc/xics_kvm.c:281:13: error: ‘ret’ may be used uninitialized in this > function [-Werror=m

[Qemu-devel] [PATCH v2] xics_kvm: fix a build break

2018-06-12 Thread Cédric Le Goater
On CentOS 7.5, gcc-4.8.5-28.el7_5.1.ppc64le fails to build QEMU due to : hw/intc/xics_kvm.c: In function ‘ics_set_kvm_state’: hw/intc/xics_kvm.c:281:13: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized] return ret; Fix the breakage and also