Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-11 Thread Alexander Graf
-...@nongnu.org; qemu- de...@nongnu.org Subject: Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61 On 06/11/2013 01:40 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Monday, June 10, 2013 11:40 PM To

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-11 Thread Bhushan Bharat-R65777
: Bhushan Bharat-R65777 > >> Cc: Wood Scott-B07421; Andreas Färber; qemu-...@nongnu.org; qemu- > >> de...@nongnu.org > >> Subject: Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer > >> for target_bit above 61 > >> > >> On 06/11/2013 01:40 PM,

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-11 Thread Bhushan Bharat-R65777
: Wood Scott-B07421 > >> Cc: Bhushan Bharat-R65777; Andreas Färber; qemu-...@nongnu.org; qemu- > >> de...@nongnu.org; Wood Scott-B07421 > >> Subject: Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer > >> for target_bit above 61 > >> > >> >

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-11 Thread Alexander Graf
-...@nongnu.org; qemu- de...@nongnu.org; Wood Scott-B07421 Subject: Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61 On 10.06.2013, at 19:20, Scott Wood wrote: On 06/10/2013 09:26:18 AM, Alexander Graf wrote: On 06/10/2013 02:47 PM, Bhushan Bharat-R65777 wrote

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-11 Thread Alexander Graf
Subject: Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61 On 10.06.2013, at 19:20, Scott Wood wrote: On 06/10/2013 09:26:18 AM, Alexander Graf wrote: On 06/10/2013 02:47 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Andreas Färber [mailto:afaer

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-11 Thread Bhushan Bharat-R65777
Message- > >>>> From: Andreas Färber [mailto:afaer...@suse.de] > >>>> Sent: Monday, June 10, 2013 5:43 PM > >>>> To: Bhushan Bharat-R65777 > >>>> Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; ag...@suse.de; Wood > >>>>

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Alexander Graf
onday, June 10, 2013 5:43 PM >>>> To: Bhushan Bharat-R65777 >>>> Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; ag...@suse.de; Wood Scott- >>>> B07421; Bhushan Bharat-R65777 >>>> Subject: Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for >

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Scott Wood
...@suse.de; Wood Scott- B07421; Bhushan Bharat-R65777 Subject: Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61 So IIUC we can only allow 63 bits due to signedness, thus a maximum of (1<< 62), thus target_bit<= 61. Any chance at least the comme

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Alexander Graf
Subject: Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61 Am 10.06.2013 09:55, schrieb Bharat Bhushan: QEMU timer supports a maximum timer of INT64_MAX. So starting timer only for time which is calculated using target_bit< 62 and deactivate/stop timer if

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Bhushan Bharat-R65777
evel] [PATCH v2]booke: timer: Deactivate timer for > target_bit above 61 > > Am 10.06.2013 09:55, schrieb Bharat Bhushan: > > QEMU timer supports a maximum timer of INT64_MAX. So starting timer > > only for time which is calculated using target_bit < 62 and > >

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Andreas Färber
Am 10.06.2013 09:55, schrieb Bharat Bhushan: > QEMU timer supports a maximum timer of INT64_MAX. So starting timer only for > time which is calculated using target_bit < 62 and deactivate/stop timer if > the target bit is above 61. > > This patch also fix the time calculation from target_bit. > Th

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Bhushan Bharat-R65777
: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for > target_bit above 61 > > On 10 June 2013 08:55, Bharat Bhushan wrote: > > QEMU timer supports a maximum timer of INT64_MAX. So starting timer > > only for time which is calculated using target_bit < 62 and > &g

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Peter Maydell
On 10 June 2013 08:55, Bharat Bhushan wrote: > QEMU timer supports a maximum timer of INT64_MAX. So starting timer only for > time which is calculated using target_bit < 62 and deactivate/stop timer if > the target bit is above 61. Is this really what the hardware does? Or do we need to set a tim

[Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Bharat Bhushan
QEMU timer supports a maximum timer of INT64_MAX. So starting timer only for time which is calculated using target_bit < 62 and deactivate/stop timer if the target bit is above 61. This patch also fix the time calculation from target_bit. The code was doing (1 << (target_bit + 1)) while this shoul