Re: [Qemu-devel] [PATCH v2 0/1] input-linux: provide hotkeys for evdev toggle

2018-01-11 Thread Gerd Hoffmann
Hi, > I wonder if it is reasonable for ui/input-linux.c to honour the same > global '-ungrab' configuration option ? No. Problem here is that input-linux is basically sniffing keyboard input when the host owns the keyboard, so it can't prevent the hotkey being seen by the host. Therefore I

Re: [Qemu-devel] [PATCH v2 0/1] input-linux: provide hotkeys for evdev toggle

2018-01-10 Thread Patrick Tseng
Hi Daniel, thanks for responding. > This should really be part of the commit message for the patch itself, so it > gets recorded in git history. Next patch version I'll separate this out to another commit. > I wonder if it is reasonable for ui/input-linux.c to honour the same > global '-ungrab'

Re: [Qemu-devel] [PATCH v2 0/1] input-linux: provide hotkeys for evdev toggle

2018-01-10 Thread Daniel P. Berrange
On Sun, Jan 07, 2018 at 02:14:54PM -0800, byxk wrote: > Added some functionality to change the key combo for evdev toggle. > example: > -object input-linux,rhotkey=29,lhotkey=56,evdev=[etc...] > > Set the defaults to LCTRL and RCTRL if not provided. This should really be part of the commit

[Qemu-devel] [PATCH v2 0/1] input-linux: provide hotkeys for evdev toggle

2018-01-07 Thread byxk
Added some functionality to change the key combo for evdev toggle. example: -object input-linux,rhotkey=29,lhotkey=56,evdev=[etc...] Set the defaults to LCTRL and RCTRL if not provided. This is my first patch to anything so feedback/help appreciated! byxk (1): input-linux: provide hotkeys for