Re: [Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors

2013-04-03 Thread Luiz Capitulino
On Wed, 3 Apr 2013 10:05:40 -0500 mdroth wrote: > On Wed, Mar 27, 2013 at 09:17:30AM -0400, Luiz Capitulino wrote: > > On Wed, 27 Mar 2013 10:10:42 +0100 > > Stefan Hajnoczi wrote: > > > > > There are several places where QEMU accidentally relies on the O_NONBLOCK > > > state > > > of passed f

Re: [Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors

2013-04-03 Thread Luiz Capitulino
On Wed, 3 Apr 2013 11:24:38 -0400 Luiz Capitulino wrote: > On Wed, 3 Apr 2013 10:05:40 -0500 > mdroth wrote: > > > On Wed, Mar 27, 2013 at 09:17:30AM -0400, Luiz Capitulino wrote: > > > On Wed, 27 Mar 2013 10:10:42 +0100 > > > Stefan Hajnoczi wrote: > > > > > > > There are several places wher

Re: [Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors

2013-04-03 Thread mdroth
On Wed, Mar 27, 2013 at 09:17:30AM -0400, Luiz Capitulino wrote: > On Wed, 27 Mar 2013 10:10:42 +0100 > Stefan Hajnoczi wrote: > > > There are several places where QEMU accidentally relies on the O_NONBLOCK > > state > > of passed file descriptors. Exposing O_NONBLOCK state makes it part of the

Re: [Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors

2013-03-27 Thread Luiz Capitulino
On Wed, 27 Mar 2013 10:10:42 +0100 Stefan Hajnoczi wrote: > There are several places where QEMU accidentally relies on the O_NONBLOCK > state > of passed file descriptors. Exposing O_NONBLOCK state makes it part of the > QMP > API whenever getfd or fdset_add_fd are used! > > Whether or not QE

Re: [Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors

2013-03-27 Thread Eric Blake
On 03/27/2013 03:10 AM, Stefan Hajnoczi wrote: > There are several places where QEMU accidentally relies on the O_NONBLOCK > state > of passed file descriptors. Exposing O_NONBLOCK state makes it part of the > QMP > API whenever getfd or fdset_add_fd are used! > > Whether or not QEMU will use O

[Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors

2013-03-27 Thread Stefan Hajnoczi
There are several places where QEMU accidentally relies on the O_NONBLOCK state of passed file descriptors. Exposing O_NONBLOCK state makes it part of the QMP API whenever getfd or fdset_add_fd are used! Whether or not QEMU will use O_NONBLOCK is an implementation detail and should be hidden from