Re: [Qemu-devel] [PATCH v2 0/5] Fix socket chardev regression

2018-08-24 Thread Peter Xu
On Fri, Aug 24, 2018 at 10:51:18AM +0200, Marc-André Lureau wrote: > Hi > > On Fri, Aug 24, 2018 at 10:45 AM Peter Xu wrote: > > > > On Fri, Aug 24, 2018 at 10:32:58AM +0200, Marc-André Lureau wrote: > > > Hi > > > > > > On Fri, Aug 24, 2018 at 5:45 AM, Peter Xu wrote: > > > > On Thu, Aug 23,

Re: [Qemu-devel] [PATCH v2 0/5] Fix socket chardev regression

2018-08-24 Thread Marc-André Lureau
Hi On Fri, Aug 24, 2018 at 10:45 AM Peter Xu wrote: > > On Fri, Aug 24, 2018 at 10:32:58AM +0200, Marc-André Lureau wrote: > > Hi > > > > On Fri, Aug 24, 2018 at 5:45 AM, Peter Xu wrote: > > > On Thu, Aug 23, 2018 at 04:31:20PM +0200, Marc-André Lureau wrote: > > >> Hi, > > >> > > >> In commit

Re: [Qemu-devel] [PATCH v2 0/5] Fix socket chardev regression

2018-08-24 Thread Marc-André Lureau
Hi On Fri, Aug 24, 2018 at 5:45 AM, Peter Xu wrote: > On Thu, Aug 23, 2018 at 04:31:20PM +0200, Marc-André Lureau wrote: >> Hi, >> >> In commit 25679e5d58e "chardev: tcp: postpone async connection setup" >> (and its follow up 99f2f54174a59), Peter moved chardev socket >> connection to

Re: [Qemu-devel] [PATCH v2 0/5] Fix socket chardev regression

2018-08-24 Thread Peter Xu
On Fri, Aug 24, 2018 at 10:32:58AM +0200, Marc-André Lureau wrote: > Hi > > On Fri, Aug 24, 2018 at 5:45 AM, Peter Xu wrote: > > On Thu, Aug 23, 2018 at 04:31:20PM +0200, Marc-André Lureau wrote: > >> Hi, > >> > >> In commit 25679e5d58e "chardev: tcp: postpone async connection setup" > >> (and

Re: [Qemu-devel] [PATCH v2 0/5] Fix socket chardev regression

2018-08-23 Thread Peter Xu
On Thu, Aug 23, 2018 at 04:31:20PM +0200, Marc-André Lureau wrote: > Hi, > > In commit 25679e5d58e "chardev: tcp: postpone async connection setup" > (and its follow up 99f2f54174a59), Peter moved chardev socket > connection to machine_done event. However, chardev created later will > no longer

[Qemu-devel] [PATCH v2 0/5] Fix socket chardev regression

2018-08-23 Thread Marc-André Lureau
Hi, In commit 25679e5d58e "chardev: tcp: postpone async connection setup" (and its follow up 99f2f54174a59), Peter moved chardev socket connection to machine_done event. However, chardev created later will no longer attempt to connect, and chardev created in tests do not have machine_done event