Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

2012-11-03 Thread Paolo Bonzini
Il 03/11/2012 16:26, Blue Swirl ha scritto: >> > It's a clang bug. The error should be suppressed, since the function is >> > used with the weak alias. >> > >> > Or try if adding "|| defined __clang__" to compiler.h fixes it. > It does. Yeah, I tested now Clang/Linux myself and reported it as htt

Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

2012-11-03 Thread Blue Swirl
On Sat, Nov 3, 2012 at 2:19 PM, Paolo Bonzini wrote: > Il 03/11/2012 12:50, Blue Swirl ha scritto: >> I'm still getting problems with Clang on Linux: >> >> CCqemu-sockets.o >> /src/qemu/qemu-sockets.c:64:12: error: function >> 'default_monitor_get_fd' is not needed and will not be emitted >>

Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

2012-11-03 Thread Paolo Bonzini
Il 03/11/2012 15:19, Paolo Bonzini ha scritto: > Il 03/11/2012 12:50, Blue Swirl ha scritto: >> I'm still getting problems with Clang on Linux: >> >> CCqemu-sockets.o >> /src/qemu/qemu-sockets.c:64:12: error: function >> 'default_monitor_get_fd' is not needed and will not be emitted >> [-Werr

Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

2012-11-03 Thread Paolo Bonzini
Il 03/11/2012 12:50, Blue Swirl ha scritto: > I'm still getting problems with Clang on Linux: > > CCqemu-sockets.o > /src/qemu/qemu-sockets.c:64:12: error: function > 'default_monitor_get_fd' is not needed and will not be emitted > [-Werror,-Wunneeded-internal-declaration] > static int defau

Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

2012-11-03 Thread Blue Swirl
On Fri, Nov 2, 2012 at 3:12 PM, Peter Maydell wrote: > On 2 November 2012 15:43, Paolo Bonzini wrote: >> Three fixes: 1) Darwin does not support weak aliases, use weak >> references instead. 2) Darwin, NetBSD and OpenBSD do not have >> sem_timedwait, implement counting semaphores with a mutex an

Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

2012-11-02 Thread Peter Maydell
On 2 November 2012 15:43, Paolo Bonzini wrote: > Three fixes: 1) Darwin does not support weak aliases, use weak > references instead. 2) Darwin, NetBSD and OpenBSD do not have > sem_timedwait, implement counting semaphores with a mutex and > cv there. 3) Daemonize was broken, fixes are in patche

[Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

2012-11-02 Thread Paolo Bonzini
Three fixes: 1) Darwin does not support weak aliases, use weak references instead. 2) Darwin, NetBSD and OpenBSD do not have sem_timedwait, implement counting semaphores with a mutex and cv there. 3) Daemonize was broken, fixes are in patches 3-5. Paolo Bonzini (5): compiler: support Darwin we