Re: [Qemu-devel] [PATCH v2 0/5] disas: add libvixl to support A64 disassembly

2014-02-04 Thread Peter Maydell
On 4 February 2014 11:47, Laurent Desnogues wrote: > On Wed, Jan 29, 2014 at 9:51 PM, Peter Maydell > wrote: >> On 29 January 2014 20:01, Laurent Desnogues >> wrote: >>> On Tue, Jan 28, 2014 at 12:45 PM, Peter Maydell >>> wrote: Ping for review/testing/comments on this version, please? >

Re: [Qemu-devel] [PATCH v2 0/5] disas: add libvixl to support A64 disassembly

2014-02-04 Thread Laurent Desnogues
On Wed, Jan 29, 2014 at 9:51 PM, Peter Maydell wrote: > On 29 January 2014 20:01, Laurent Desnogues > wrote: >> On Tue, Jan 28, 2014 at 12:45 PM, Peter Maydell >> wrote: >>> Ping for review/testing/comments on this version, please? >> >> I still dislike the idea of importing so much code in par

Re: [Qemu-devel] [PATCH v2 0/5] disas: add libvixl to support A64 disassembly

2014-01-29 Thread Peter Maydell
On 29 January 2014 20:01, Laurent Desnogues wrote: > On Tue, Jan 28, 2014 at 12:45 PM, Peter Maydell > wrote: >> Ping for review/testing/comments on this version, please? > > I still dislike the idea of importing so much code in particular for > something that is incomplete: as far as I can see,

Re: [Qemu-devel] [PATCH v2 0/5] disas: add libvixl to support A64 disassembly

2014-01-29 Thread Laurent Desnogues
On Tue, Jan 28, 2014 at 12:45 PM, Peter Maydell wrote: > Ping for review/testing/comments on this version, please? I still dislike the idea of importing so much code in particular for something that is incomplete: as far as I can see, AdvSIMD instructions are not supported. The very least that

Re: [Qemu-devel] [PATCH v2 0/5] disas: add libvixl to support A64 disassembly

2014-01-29 Thread Richard Henderson
On 01/28/2014 03:45 AM, Peter Maydell wrote: > Ping for review/testing/comments on this version, please? I skipped the contents of libvixl itself, but the configure and interface changes look ok to me. Reviewed-by: Richard Henderson r~ > > thanks > -- PMM > > On 16 January 2014 11:13, Pete

Re: [Qemu-devel] [PATCH v2 0/5] disas: add libvixl to support A64 disassembly

2014-01-28 Thread Peter Maydell
Ping for review/testing/comments on this version, please? thanks -- PMM On 16 January 2014 11:13, Peter Maydell wrote: > Hi. This is a rebased and mildly cleaned up version of Claudio's > RFC patchset from last year to add libvixl to QEMU and use it > for A64 disassembly. > > NOTE NOTE NOTE > *

[Qemu-devel] [PATCH v2 0/5] disas: add libvixl to support A64 disassembly

2014-01-16 Thread Peter Maydell
Hi. This is a rebased and mildly cleaned up version of Claudio's RFC patchset from last year to add libvixl to QEMU and use it for A64 disassembly. NOTE NOTE NOTE * we now link with g++, not gcc (even if the target doesn't happen to need the A64 disassembler, since it's a bit hard to tell w