Re: [Qemu-devel] [PATCH v2 0/7] Poison some more target-specific defines

2017-06-16 Thread Thomas Huth
On 16.06.2017 17:55, Paolo Bonzini wrote: > > > On 16/06/2017 17:21, Thomas Huth wrote: >>> Why do you say they can't be moved? They can, and your series should >>> change nothing about it, thanks to what you're doing now with >>> CONFIG_KVM_IS_POSSIBLE (which was also done before with

Re: [Qemu-devel] [PATCH v2 0/7] Poison some more target-specific defines

2017-06-16 Thread Paolo Bonzini
On 16/06/2017 18:15, Thomas Huth wrote: > This is quite similar to trying to poison CONFIG_USER_ONLY ... every > common file that depends on include/exec/memory.h or > /include/exec/cpu-common.h then does not compile anymore - and as far as > I can see, this can't be fixed with some trivial

Re: [Qemu-devel] [PATCH v2 0/7] Poison some more target-specific defines

2017-06-16 Thread Paolo Bonzini
On 16/06/2017 17:21, Thomas Huth wrote: >> Why do you say they can't be moved? They can, and your series should >> change nothing about it, thanks to what you're doing now with >> CONFIG_KVM_IS_POSSIBLE (which was also done before with NEED_CPU_H). > numa.c and balloon.c both use ram_addr_t

Re: [Qemu-devel] [PATCH v2 0/7] Poison some more target-specific defines

2017-06-16 Thread Thomas Huth
On 16.06.2017 17:05, Paolo Bonzini wrote: > On 16/06/2017 16:59, Thomas Huth wrote: >> This series marks some more #defines as poisoned, which are >> target-specific (declared in config-target.h) and thus must >> not be used in common code. >> >> v2: >> - First two patches are the same as in v1

Re: [Qemu-devel] [PATCH v2 0/7] Poison some more target-specific defines

2017-06-16 Thread Paolo Bonzini
On 16/06/2017 16:59, Thomas Huth wrote: > This series marks some more #defines as poisoned, which are > target-specific (declared in config-target.h) and thus must > not be used in common code. > > v2: > - First two patches are the same as in v1 > - Reworked the CONFIG_KVM patches according to

[Qemu-devel] [PATCH v2 0/7] Poison some more target-specific defines

2017-06-16 Thread Thomas Huth
This series marks some more #defines as poisoned, which are target-specific (declared in config-target.h) and thus must not be used in common code. v2: - First two patches are the same as in v1 - Reworked the CONFIG_KVM patches according to Paolo's review feedback - Added two new patches to