Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up

2012-10-28 Thread Evgeny Voevodin
On 10/27/2012 06:34 PM, Blue Swirl wrote: On Fri, Oct 26, 2012 at 6:32 AM, Evgeny Voevodin wrote: Today I made more precise testing with usage of --enable-profiler. Here is the test procedure: 1. Boot Linux Kernel 5 times. 2. For each iteration wait while "JIT cycles" is stable for ~10 seconds

Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up

2012-10-27 Thread Blue Swirl
On Fri, Oct 26, 2012 at 6:32 AM, Evgeny Voevodin wrote: > Today I made more precise testing with usage of --enable-profiler. > > Here is the test procedure: > 1. Boot Linux Kernel 5 times. > 2. For each iteration wait while "JIT cycles" is stable for ~10 seconds > 3. Write down the "cycles/op" > >

Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up

2012-10-25 Thread Evgeny Voevodin
Today I made more precise testing with usage of --enable-profiler. Here is the test procedure: 1. Boot Linux Kernel 5 times. 2. For each iteration wait while "JIT cycles" is stable for ~10 seconds 3. Write down the "cycles/op" Here are the results: Before clean-up: min: 731.9 max: 735.8 avg: 73

Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up

2012-10-24 Thread Evgeny Voevodin
Here are the results of tests before and after this patch series was applied: * EEMBC CoreMark (before -> after) - Guest: Exynos4210 ARMv7, Linux (Custom buildroot image) - Host: Intel(R) Core(TM) i5 CPU 750 @ 2.67GHz, 4GB RAM, Linux - Results: 1148.105626 -> 1161.440186 (+1.16%) * nbench

Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up

2012-10-24 Thread Evgeny Voevodin
On 10/25/2012 07:17 AM, 陳韋任 (Wei-Ren Chen) wrote: On Thu, Oct 25, 2012 at 07:06:37AM +0400, Evgeny Voevodin wrote: Any other comments on the patches? I didn't get the consensus. Do we need a pointer to tcg context? As I said before, I didn't notice any slow-down with it. On 10/23/2012 10:21 AM,

Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up

2012-10-24 Thread Wei-Ren Chen
On Thu, Oct 25, 2012 at 07:06:37AM +0400, Evgeny Voevodin wrote: > Any other comments on the patches? > I didn't get the consensus. Do we need a pointer to tcg context? > As I said before, I didn't notice any slow-down with it. > > On 10/23/2012 10:21 AM, Evgeny Voevodin wrote: > > This set of pat

Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up

2012-10-24 Thread Evgeny Voevodin
Any other comments on the patches? I didn't get the consensus. Do we need a pointer to tcg context? As I said before, I didn't notice any slow-down with it. On 10/23/2012 10:21 AM, Evgeny Voevodin wrote: This set of patches moves global variables to tcg_ctx: gen_opc_ptr gen_opparam_ptr gen_opc_b

Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up

2012-10-23 Thread Evgeny Voevodin
On 10/23/2012 10:21 AM, Evgeny Voevodin wrote: This set of patches moves global variables to tcg_ctx: gen_opc_ptr gen_opparam_ptr gen_opc_buf gen_opparam_buf Build tested for all targets. Execution tested on ARM. I didn't notice any slow-down of kernel boot after this set was applied. Changelo

[Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up

2012-10-23 Thread Evgeny Voevodin
This set of patches moves global variables to tcg_ctx: gen_opc_ptr gen_opparam_ptr gen_opc_buf gen_opparam_buf Build tested for all targets. Execution tested on ARM. I didn't notice any slow-down of kernel boot after this set was applied. Changelog: v1->v2: Introduced TCGContext *tcg_cur_ctx glo