Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-10-12 Thread Xiao Guangrong
On 10/11/2016 08:32 PM, Igor Mammedov wrote: Of course, @fit and @current_number should be persistent during live migration. you can drop RCU and @current_number, and @fit could be exactly recreated on target side from -device nvdim ... set of options, which must include all currently prese

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-10-11 Thread Igor Mammedov
On Mon, 10 Oct 2016 21:57:55 +0800 Xiao Guangrong wrote: > On 10/10/2016 08:59 PM, Igor Mammedov wrote: > > On Sat, 8 Oct 2016 16:34:06 +0800 > > Xiao Guangrong wrote: > > > >> On 10/03/2016 09:48 PM, Igor Mammedov wrote: > >>> On Fri, 12 Aug 2016 14:54:02 +0800 > >>> Xiao Guangrong wrote:

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-10-10 Thread Xiao Guangrong
On 10/10/2016 08:59 PM, Igor Mammedov wrote: On Sat, 8 Oct 2016 16:34:06 +0800 Xiao Guangrong wrote: On 10/03/2016 09:48 PM, Igor Mammedov wrote: On Fri, 12 Aug 2016 14:54:02 +0800 Xiao Guangrong wrote: General design issue in this series is regenerating _FIT data every time inside of _FI

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-10-10 Thread Igor Mammedov
On Sat, 8 Oct 2016 16:34:06 +0800 Xiao Guangrong wrote: > On 10/03/2016 09:48 PM, Igor Mammedov wrote: > > On Fri, 12 Aug 2016 14:54:02 +0800 > > Xiao Guangrong wrote: > > > > General design issue in this series is regenerating > > _FIT data every time inside of _FIT read loop. > > > > The issue

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-10-08 Thread Xiao Guangrong
On 10/03/2016 09:48 PM, Igor Mammedov wrote: On Fri, 12 Aug 2016 14:54:02 +0800 Xiao Guangrong wrote: General design issue in this series is regenerating _FIT data every time inside of _FIT read loop. The issue here is that if FIT data doesn't fit in one page RFIT would be called several tim

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-10-03 Thread Igor Mammedov
On Fri, 12 Aug 2016 14:54:02 +0800 Xiao Guangrong wrote: General design issue in this series is regenerating _FIT data every time inside of _FIT read loop. The issue here is that if FIT data doesn't fit in one page RFIT would be called several times resulting in calling nvdimm_dsm_func_read_fit(

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-09-12 Thread Igor Mammedov
On Mon, 12 Sep 2016 15:33:53 +0800 Xiao Guangrong wrote: > On 08/12/2016 11:13 PM, Igor Mammedov wrote: > > >> > >> Reviewed-by: Stefan Hajnoczi > > I'd like to review it but I need to read NVDIMM/ACPI specs first > > to make sensible comments. > > > > However it will take some time and I'm o

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-09-12 Thread Xiao Guangrong
On 08/12/2016 11:13 PM, Igor Mammedov wrote: Reviewed-by: Stefan Hajnoczi I'd like to review it but I need to read NVDIMM/ACPI specs first to make sensible comments. However it will take some time and I'm on vacation starting next week and I'll be back in a month. So please don't apply thi

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-18 Thread Dan Williams
On Thu, Aug 18, 2016 at 8:46 PM, Xiao Guangrong wrote: > > > On 08/19/2016 11:40 AM, Xiao Guangrong wrote: >> >> >> >> On 08/19/2016 02:54 AM, Vishal Verma wrote: >>> >>> On 08/18, Dan Williams wrote: [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] >

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-18 Thread Xiao Guangrong
On 08/19/2016 11:40 AM, Xiao Guangrong wrote: On 08/19/2016 02:54 AM, Vishal Verma wrote: On 08/18, Dan Williams wrote: [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong wrote: This patchset is against commit c597

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-18 Thread Xiao Guangrong
On 08/19/2016 02:54 AM, Vishal Verma wrote: On 08/18, Dan Williams wrote: [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong wrote: This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing rx queue

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-18 Thread Vishal Verma
On 08/18, Dan Williams wrote: > [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] > > On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong > wrote: > > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > > rx queue siz) on pci branch of Michael's gi

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-18 Thread Dan Williams
[ adding Vishal who implemented the kernel side of nvdimm hotplug support ] On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong wrote: > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > rx queue siz) on pci branch of Michael's git tree and can be found at: > https:

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-12 Thread Igor Mammedov
On Fri, 12 Aug 2016 09:35:12 +0100 Stefan Hajnoczi wrote: > On Fri, Aug 12, 2016 at 02:54:02PM +0800, Xiao Guangrong wrote: > > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > > rx queue siz) on pci branch of Michael's git tree and can be found at: > > https://

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-12 Thread Stefan Hajnoczi
On Fri, Aug 12, 2016 at 02:54:02PM +0800, Xiao Guangrong wrote: > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > rx queue siz) on pci branch of Michael's git tree and can be found at: > https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2 > > Changelog in v2: >

[Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-12 Thread Xiao Guangrong
This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing rx queue siz) on pci branch of Michael's git tree and can be found at: https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2 Changelog in v2: Fixed signed integer overflow pointed out by Stefan Hajnoczi This patch