Re: [Qemu-devel] [PATCH v2 00/15] PATCH 00/15] NVDIMM: introduce nvdimm label support

2016-05-30 Thread Xiao Guangrong
On 05/31/2016 02:52 AM, Stefan Hajnoczi wrote: I have reviewed the non-ACPI parts of this series. Aside from minor comments: Reviewed-by: Stefan Hajnoczi Really appreciate all your review! Thanks your, Stefan!

Re: [Qemu-devel] [PATCH v2 00/15] PATCH 00/15] NVDIMM: introduce nvdimm label support

2016-05-30 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 04:19:57PM +0800, Xiao Guangrong wrote: > Changelog in v2: > Thanks for Stefan's review, the changes in this version are: > - rename nvdimm device parameter 'reserve-label' to 'label-size' to > specify the size of label > - add comment to explain why assert() used in

[Qemu-devel] [PATCH v2 00/15] PATCH 00/15] NVDIMM: introduce nvdimm label support

2016-05-20 Thread Xiao Guangrong
Changelog in v2: Thanks for Stefan's review, the changes in this version are: - rename nvdimm device parameter 'reserve-label' to 'label-size' to specify the size of label - add comment to explain why assert() used in nvdimm_assert_rw_label_data() is safe - follow the code style of 'foo()