I think you're on the right track. I like your systematic approach.
Sorry for taking way too long to review. You deserve better!
No longer applies cleanly, but git-am -3 takes care of everything except
for a trivial #include conflict. I didn't test the result, though :)
On Tue, 5 Feb 2013 21:39:13 +0100
Laszlo Ersek wrote:
> In v2, I'm mostly attempting to address Luiz's comments for v1:
Apart from minor comments, looks good to me.
Not sure if I did a good job on trying to suggest you a better
splitting though.
Also, I think it's a good idea for someone more
In v2, I'm mostly attempting to address Luiz's comments for v1:
- (rebase to b22dd124,)
- return "void" from a converted function if retval used to communicate
error/success only,
- rebase error check from retval to returned Error wherever possible,
- formulate interface contract of qbus_find_re
