Re: [Qemu-devel] [PATCH v2 00/15] virtio-crypto: introduce framework and device emulation

2016-09-13 Thread Daniel P. Berrange
On Tue, Sep 13, 2016 at 12:58:59PM +0200, Paolo Bonzini wrote: > > > On 13/09/2016 11:54, Daniel P. Berrange wrote: > > > OK, I agree with you :) But if we support multiple backends, can > > > we keep cryptodev-linux module as one option? > > > > I'm personally against any support for out of tre

Re: [Qemu-devel] [PATCH v2 00/15] virtio-crypto: introduce framework and device emulation

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 11:54, Daniel P. Berrange wrote: > > OK, I agree with you :) But if we support multiple backends, can > > we keep cryptodev-linux module as one option? > > I'm personally against any support for out of tree kernel modules > in QEMU, regardless of whether QEMU also implements altern

Re: [Qemu-devel] [PATCH v2 00/15] virtio-crypto: introduce framework and device emulation

2016-09-13 Thread Gonglei (Arei)
> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, September 13, 2016 5:54 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org; Huangpeng > (Peter); Luonengjun; m...@redhat.com; stefa...@redhat.com; > pbonz...@red

Re: [Qemu-devel] [PATCH v2 00/15] virtio-crypto: introduce framework and device emulation

2016-09-13 Thread Daniel P. Berrange
On Tue, Sep 13, 2016 at 09:45:05AM +, Gonglei (Arei) wrote: > Hi Daniel, > > Thanks for your comments fristly, please see my embedded reply. > > Regards, > -Gonglei > > > > -Original Message- > > From: Daniel P. Berrange [mailto:berra...@redhat.com] > > Sent: Tuesday, September 13,

Re: [Qemu-devel] [PATCH v2 00/15] virtio-crypto: introduce framework and device emulation

2016-09-13 Thread Gonglei (Arei)
Hi Daniel, Thanks for your comments fristly, please see my embedded reply. Regards, -Gonglei > -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, September 13, 2016 4:58 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; virtio-...@lists.oasis-

Re: [Qemu-devel] [PATCH v2 00/15] virtio-crypto: introduce framework and device emulation

2016-09-13 Thread Daniel P. Berrange
On Tue, Sep 13, 2016 at 11:52:06AM +0800, Gonglei wrote: > Changes since v1: > - rmmove mixed endian-ness handler for virtio-crypto device, just >use little-endian. [mst] > - add sg list support according virtio-crypto spec v10 (will be posted soon). > - fix a memory leak in session handler.

[Qemu-devel] [PATCH v2 00/15] virtio-crypto: introduce framework and device emulation

2016-09-12 Thread Gonglei
Changes since v1: - rmmove mixed endian-ness handler for virtio-crypto device, just use little-endian. [mst] - add sg list support according virtio-crypto spec v10 (will be posted soon). - fix a memory leak in session handler. - add a feature page link in qemu.org (http://qemu-project.org/F