Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c

2012-07-31 Thread Stefan Hajnoczi
On Tue, Jul 31, 2012 at 10:22:37AM +0800, Zhi Yong Wu wrote: > On Mon, Jul 30, 2012 at 11:49 PM, Stefan Hajnoczi wrote: > > On Tue, Jul 24, 2012 at 4:35 PM, Stefan Hajnoczi > > wrote: > >> [These patches are based on the net tree at git://github.com/stefanha/net] > >> > >> The QEMU net subsystem

Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c

2012-07-30 Thread Zhi Yong Wu
On Mon, Jul 30, 2012 at 11:49 PM, Stefan Hajnoczi wrote: > On Tue, Jul 24, 2012 at 4:35 PM, Stefan Hajnoczi > wrote: >> [These patches are based on the net tree at git://github.com/stefanha/net] >> >> The QEMU net subsystem has the concept of separate network segments, called >> "VLANs". Each VL

Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c

2012-07-30 Thread Stefan Hajnoczi
On Tue, Jul 24, 2012 at 4:35 PM, Stefan Hajnoczi wrote: > [These patches are based on the net tree at git://github.com/stefanha/net] > > The QEMU net subsystem has the concept of separate network segments, called > "VLANs". Each VLAN is a broadcast domain so all net clients connected to the > sam

Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c

2012-07-25 Thread Laszlo Ersek
On 07/24/12 17:35, Stefan Hajnoczi wrote: > v2: > * Change int64_t and unsigned int mess to int which is what VLAN IDs are > today [Laszlo] > * Remove bogus error_set() -> qerror_report() merge artifact [Laszlo] > * Use net_hub_id_for_client(nc, NULL) == 0 instead of adding > net_hub_port_pee

Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c

2012-07-24 Thread Laszlo Ersek
I'd like to review v2 tomorrow (ahem, today), ie. not right now, but this catches my eye: On 07/24/12 17:35, Stefan Hajnoczi wrote: > * Drop spurious closesocket(fd), probably merge conflict [Stefan] I saw it last time and I thought you had fixed a leak with it on the side. The function looks a

[Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c

2012-07-24 Thread Stefan Hajnoczi
[These patches are based on the net tree at git://github.com/stefanha/net] The QEMU net subsystem has the concept of separate network segments, called "VLANs". Each VLAN is a broadcast domain so all net clients connected to the same VLAN can communicate with each other. Today this feature is mos