Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI

2015-02-10 Thread Stefan Hajnoczi
On Tue, Dec 16, 2014 at 08:35:50PM -0500, John Snow wrote: This series was written mostly by Paolo Bonzini to do two things: 1. Unify the restart callbacks for ISA, AHCI and BMDMA 2. Ensure we can restart a command after migration Many of the early patches only make much sense considering

Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI

2015-01-30 Thread John Snow
On 01/30/2015 04:38 AM, Paolo Bonzini wrote: On 30/01/2015 01:44, John Snow wrote: Post-holiday bump that this is sitting out there, awaiting love. If this gets merged, we should be able to enable Q35 migration soon, which would be nice. Not sure how valuable my opinion is as the author

Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI

2015-01-30 Thread Paolo Bonzini
On 30/01/2015 01:44, John Snow wrote: Post-holiday bump that this is sitting out there, awaiting love. If this gets merged, we should be able to enable Q35 migration soon, which would be nice. Not sure how valuable my opinion is as the author of around 85% of the series... So I reviewed the

Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI

2015-01-29 Thread John Snow
Post-holiday bump that this is sitting out there, awaiting love. If this gets merged, we should be able to enable Q35 migration soon, which would be nice. --js On 12/16/2014 08:35 PM, John Snow wrote: This series was written mostly by Paolo Bonzini to do two things: 1. Unify the restart

Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI

2014-12-17 Thread Markus Armbruster
John Snow js...@redhat.com writes: This series was written mostly by Paolo Bonzini to do two things: 1. Unify the restart callbacks for ISA, AHCI and BMDMA 2. Ensure we can restart a command after migration Many of the early patches only make much sense considering the end-goal of

Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI

2014-12-17 Thread Paolo Bonzini
On 17/12/2014 09:23, Markus Armbruster wrote: I had to read this twice to even guess how this is related to the stated subject ide: rerror and werror support for IDE and AHCI :) IDE already supports rerror and werror. I guess this series fixes migration bugs that can bite when

Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI

2014-12-17 Thread John Snow
On 12/17/2014 04:37 AM, Paolo Bonzini wrote: On 17/12/2014 09:23, Markus Armbruster wrote: I had to read this twice to even guess how this is related to the stated subject ide: rerror and werror support for IDE and AHCI :) IDE already supports rerror and werror. I guess this series fixes

[Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI

2014-12-16 Thread John Snow
This series was written mostly by Paolo Bonzini to do two things: 1. Unify the restart callbacks for ISA, AHCI and BMDMA 2. Ensure we can restart a command after migration Many of the early patches only make much sense considering the end-goal of eliminating BMDMA specific restart code to be