Re: [Qemu-devel] [PATCH v2 00/38] pci: initialize ids in pci common code

2011-05-18 Thread Michael S. Tsirkin
On Wed, May 18, 2011 at 01:55:17AM +0900, Isaku Yamahata wrote: vender id/device id... in pci configuration space are read-only registers which are commonly defined for all pci devices. So initialize them in common code and it simplifies the initialization a bit. I didn't converted virtio-pci

Re: [Qemu-devel] [PATCH v2 00/38] pci: initialize ids in pci common code

2011-05-18 Thread Gerd Hoffmann
Hi, qxl has a property to convert device id to 'development' and to tweak revision through a qdev property. Gerd, could you comment on why this is useful? I think we can zap this, was in use for a while one year ago, but in the end it turned out we can keep qxl compatible to older versions

Re: [Qemu-devel] [PATCH v2 00/38] pci: initialize ids in pci common code

2011-05-18 Thread Isaku Yamahata
On Wed, May 18, 2011 at 12:17:46PM +0300, Michael S. Tsirkin wrote: On Wed, May 18, 2011 at 01:55:17AM +0900, Isaku Yamahata wrote: vender id/device id... in pci configuration space are read-only registers which are commonly defined for all pci devices. So initialize them in common code and

Re: [Qemu-devel] [PATCH v2 00/38] pci: initialize ids in pci common code

2011-05-18 Thread Michael S. Tsirkin
On Wed, May 18, 2011 at 07:55:17PM +0900, Isaku Yamahata wrote: On Wed, May 18, 2011 at 12:17:46PM +0300, Michael S. Tsirkin wrote: On Wed, May 18, 2011 at 01:55:17AM +0900, Isaku Yamahata wrote: vender id/device id... in pci configuration space are read-only registers which are commonly

Re: [Qemu-devel] [PATCH v2 00/38] pci: initialize ids in pci common code

2011-05-18 Thread Michael S. Tsirkin
On Wed, May 18, 2011 at 07:55:17PM +0900, Isaku Yamahata wrote: On Wed, May 18, 2011 at 12:17:46PM +0300, Michael S. Tsirkin wrote: On Wed, May 18, 2011 at 01:55:17AM +0900, Isaku Yamahata wrote: vender id/device id... in pci configuration space are read-only registers which are commonly

Re: [Qemu-devel] [PATCH v2 00/38] pci: initialize ids in pci common code

2011-05-18 Thread Gerd Hoffmann
Hi, Well the devel device id can go it seems, but we need think what to do with the revision. Maybe it's not so terrible that revision will be wrong in -help for qxl - any better ideas? Fine with me. Default is 2 and it can be set to 1 using rev=1 property if needed. Help should show rev

Re: [Qemu-devel] [PATCH v2 00/38] pci: initialize ids in pci common code

2011-05-18 Thread Michael S. Tsirkin
On Wed, May 18, 2011 at 03:07:21PM +0200, Gerd Hoffmann wrote: Hi, Well the devel device id can go it seems, but we need think what to do with the revision. Maybe it's not so terrible that revision will be wrong in -help for qxl - any better ideas? Fine with me. Default is 2 and it

[Qemu-devel] [PATCH v2 00/38] pci: initialize ids in pci common code

2011-05-17 Thread Isaku Yamahata
vender id/device id... in pci configuration space are read-only registers which are commonly defined for all pci devices. So initialize them in common code and it simplifies the initialization a bit. I didn't converted virtio-pci and qxl because it determines ids dynaically. So I'll leave those

Re: [Qemu-devel] [PATCH v2 00/38] pci: initialize ids in pci common code

2011-05-17 Thread Isaku Yamahata
Here is the prog_interface part. You were unsure about prog_interface, so I split it out. Thus you can determine if prog_interface conversion is wanted or not. From abaf67175190c2f4d0c222c2ae8010e9de38bf59 Mon Sep 17 00:00:00 2001 Message-Id: