Re: [Qemu-devel] [PATCH v2 000/108] linux-user: Split do_syscall

2018-06-10 Thread Richard Henderson
On 06/09/2018 05:00 PM, Richard Henderson wrote: > * Changed the table into a switch, for the reason documented. > Use macros to actually enter the syscall into the switch. > * Finish the split. > * Fix some bugs along the way. I forgot to mention, this is based on https://lists.gnu.org/archive

Re: [Qemu-devel] [PATCH v2 000/108] linux-user: Split do_syscall

2018-06-10 Thread Richard Henderson
On 06/10/2018 02:34 AM, Peter Maydell wrote: > It's still a stupidly large source file -- is it worth taking > advantage of the split into multiple implementation functions > to break it up into multiple source files? (We could group > related syscalls together.) It's possible. Any suggestions fo

Re: [Qemu-devel] [PATCH v2 000/108] linux-user: Split do_syscall

2018-06-10 Thread Peter Maydell
On 10 June 2018 at 04:00, Richard Henderson wrote: > * Changed the table into a switch, for the reason documented. > Use macros to actually enter the syscall into the switch. > * Finish the split. > * Fix some bugs along the way. > > I know it's a huge patch set, but I guess it was always going

Re: [Qemu-devel] [PATCH v2 000/108] linux-user: Split do_syscall

2018-06-09 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180610030220.3777-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v2 000/108] linux-user: Split do_syscall === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH v2 000/108] linux-user: Split do_syscall

2018-06-09 Thread Richard Henderson
* Changed the table into a switch, for the reason documented. Use macros to actually enter the syscall into the switch. * Finish the split. * Fix some bugs along the way. I know it's a huge patch set, but I guess it was always going to be in order to finish -- it was a stupidly large function.