Re: [Qemu-devel] [PATCH v2 01/10] ipmi: remove IPMI_CHECK_CMD_LEN() macro

2016-03-09 Thread Cédric Le Goater
On 03/09/2016 05:07 AM, Corey Minyard wrote: > On 03/09/2016 12:06 AM, Cédric Le Goater wrote: >> On 03/07/2016 11:40 AM, Cédric Le Goater wrote: >>> On 03/05/2016 12:41 PM, Corey Minyard wrote: On 03/02/2016 04:14 AM, Cédric Le Goater wrote: > Most IPMI command handlers in the BMC simulat

Re: [Qemu-devel] [PATCH v2 01/10] ipmi: remove IPMI_CHECK_CMD_LEN() macro

2016-03-08 Thread Corey Minyard
On 03/09/2016 12:06 AM, Cédric Le Goater wrote: On 03/07/2016 11:40 AM, Cédric Le Goater wrote: On 03/05/2016 12:41 PM, Corey Minyard wrote: On 03/02/2016 04:14 AM, Cédric Le Goater wrote: Most IPMI command handlers in the BMC simulator start with a call to the macro IPMI_CHECK_CMD_LEN() which

Re: [Qemu-devel] [PATCH v2 01/10] ipmi: remove IPMI_CHECK_CMD_LEN() macro

2016-03-08 Thread Cédric Le Goater
On 03/07/2016 11:40 AM, Cédric Le Goater wrote: > On 03/05/2016 12:41 PM, Corey Minyard wrote: >> On 03/02/2016 04:14 AM, Cédric Le Goater wrote: >>> Most IPMI command handlers in the BMC simulator start with a call to >>> the macro IPMI_CHECK_CMD_LEN() which verifies that a minimal number of >>> a

Re: [Qemu-devel] [PATCH v2 01/10] ipmi: remove IPMI_CHECK_CMD_LEN() macro

2016-03-07 Thread Cédric Le Goater
On 03/05/2016 12:41 PM, Corey Minyard wrote: > On 03/02/2016 04:14 AM, Cédric Le Goater wrote: >> Most IPMI command handlers in the BMC simulator start with a call to >> the macro IPMI_CHECK_CMD_LEN() which verifies that a minimal number of >> arguments expected by the command are indeed available.

Re: [Qemu-devel] [PATCH v2 01/10] ipmi: remove IPMI_CHECK_CMD_LEN() macro

2016-03-05 Thread Corey Minyard
On 03/02/2016 04:14 AM, Cédric Le Goater wrote: Most IPMI command handlers in the BMC simulator start with a call to the macro IPMI_CHECK_CMD_LEN() which verifies that a minimal number of arguments expected by the command are indeed available. To achieve this task, the macro implicitly uses local

[Qemu-devel] [PATCH v2 01/10] ipmi: remove IPMI_CHECK_CMD_LEN() macro

2016-03-02 Thread Cédric Le Goater
Most IPMI command handlers in the BMC simulator start with a call to the macro IPMI_CHECK_CMD_LEN() which verifies that a minimal number of arguments expected by the command are indeed available. To achieve this task, the macro implicitly uses local variables which is misleading in the code. This