Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-08 Thread Cédric Le Goater
On 09/07/2016 11:48 PM, Benjamin Herrenschmidt wrote: > On Wed, 2016-09-07 at 14:13 +0200, Cédric Le Goater wrote: >> On 09/07/2016 01:08 PM, Benjamin Herrenschmidt wrote: >>> >>> On Wed, 2016-09-07 at 12:50 +0200, Cédric Le Goater wrote: This is a bit broader than Ben's patch which used

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-07 Thread Benjamin Herrenschmidt
On Wed, 2016-09-07 at 14:13 +0200, Cédric Le Goater wrote: > On 09/07/2016 01:08 PM, Benjamin Herrenschmidt wrote: > > > > On Wed, 2016-09-07 at 12:50 +0200, Cédric Le Goater wrote: > > > > > > This is a bit broader than Ben's patch which used > > > PPC_SEGMENT_64B.  > > > it's basically

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-07 Thread Cédric Le Goater
On 09/07/2016 01:08 PM, Benjamin Herrenschmidt wrote: > On Wed, 2016-09-07 at 12:50 +0200, Cédric Le Goater wrote: >> This is a bit broader than Ben's patch which used PPC_SEGMENT_64B. >> it's basically !PPC_64B which includes the e5500. >> >> If so, here is a proposal below adding a new PPC_RFI

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-07 Thread Benjamin Herrenschmidt
On Wed, 2016-09-07 at 12:50 +0200, Cédric Le Goater wrote: > This is a bit broader than Ben's patch which used PPC_SEGMENT_64B.  > it's basically !PPC_64B which includes the e5500. > > If so, here is a proposal below adding a new PPC_RFI in the  > "PowerPC Instructions types definitions" enum for

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-07 Thread Cédric Le Goater
On 09/06/2016 09:07 AM, Mark Cave-Ayland wrote: > On 06/09/16 01:16, David Gibson wrote: > >> On Mon, Sep 05, 2016 at 09:51:09PM +0100, Mark Cave-Ayland wrote: >>> On 05/09/16 21:30, Cédric Le Goater wrote: >>> > Shall we disable rfi now for QEMU 2.8 ? Cédric, could you maybe send a >

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-06 Thread Mark Cave-Ayland
On 06/09/16 01:16, David Gibson wrote: > On Mon, Sep 05, 2016 at 09:51:09PM +0100, Mark Cave-Ayland wrote: >> On 05/09/16 21:30, Cédric Le Goater wrote: >> Shall we disable rfi now for QEMU 2.8 ? Cédric, could you maybe send a patch with that hunk again? >>> >>> Sure. I have kept it in

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-05 Thread David Gibson
On Mon, Sep 05, 2016 at 09:51:09PM +0100, Mark Cave-Ayland wrote: > On 05/09/16 21:30, Cédric Le Goater wrote: > > >> Shall we disable rfi now for QEMU 2.8 ? Cédric, could you maybe send a > >> patch with that hunk again? > > > > Sure. I have kept it in a warm place here : > > > > > >

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-05 Thread Mark Cave-Ayland
On 05/09/16 21:30, Cédric Le Goater wrote: >> Shall we disable rfi now for QEMU 2.8 ? Cédric, could you maybe send a >> patch with that hunk again? > > Sure. I have kept it in a warm place here : > > > https://github.com/legoater/qemu/commit/492a631e4e817863be312c1a34957cd8d679a56c >

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-05 Thread Cédric Le Goater
On 09/05/2016 10:25 PM, Thomas Huth wrote: > On 23.06.2016 07:50, David Gibson wrote: >> On Wed, Jun 22, 2016 at 08:48:14AM +0200, Cédric Le Goater wrote: >>> On 06/22/2016 04:46 AM, David Gibson wrote: I'm not comfortable merging this until the openbios change is pulled back into the

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-05 Thread Thomas Huth
On 23.06.2016 07:50, David Gibson wrote: > On Wed, Jun 22, 2016 at 08:48:14AM +0200, Cédric Le Goater wrote: >> On 06/22/2016 04:46 AM, David Gibson wrote: >>> I'm not comfortable merging this until the openbios change is pulled >>> back into the qemu tree (submodule and pre-built binary). >>> >>>

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-23 Thread David Gibson
On Thu, Jun 23, 2016 at 08:08:38AM +0200, Cédric Le Goater wrote: > On 06/23/2016 07:50 AM, David Gibson wrote: > > On Wed, Jun 22, 2016 at 08:48:14AM +0200, Cédric Le Goater wrote: > >> On 06/22/2016 04:46 AM, David Gibson wrote: > >>> I'm not comfortable merging this until the openbios change is

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-23 Thread Cédric Le Goater
On 06/23/2016 07:50 AM, David Gibson wrote: > On Wed, Jun 22, 2016 at 08:48:14AM +0200, Cédric Le Goater wrote: >> On 06/22/2016 04:46 AM, David Gibson wrote: >>> I'm not comfortable merging this until the openbios change is pulled >>> back into the qemu tree (submodule and pre-built binary). >>>

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-23 Thread David Gibson
On Wed, Jun 22, 2016 at 08:48:14AM +0200, Cédric Le Goater wrote: > On 06/22/2016 04:46 AM, David Gibson wrote: > > I'm not comfortable merging this until the openbios change is pulled > > back into the qemu tree (submodule and pre-built binary). > > > > Again - sure you don't want to apply this

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-22 Thread Cédric Le Goater
On 06/22/2016 04:46 AM, David Gibson wrote: > I'm not comfortable merging this until the openbios change is pulled > back into the qemu tree (submodule and pre-built binary). > > Again - sure you don't want to apply this with rfi still enabled for > 64-bit for now, letting the rest of this series

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-21 Thread David Gibson
On Tue, Jun 21, 2016 at 11:48:46PM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > This reworks emulation of the various "rfi" variants. I removed > some masking bits that I couldn't make sense of, the only bit that > I am aware we should mask here is

[Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-21 Thread Cédric Le Goater
From: Benjamin Herrenschmidt This reworks emulation of the various "rfi" variants. I removed some masking bits that I couldn't make sense of, the only bit that I am aware we should mask here is POW, the CPU's MSR mask should take care of the rest. This also fixes some