Re: [Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature for Security Extensions

2014-05-22 Thread Aggeler Fabian
On 21 May 2014, at 16:51, Peter Maydell wrote: > On 13 May 2014 17:15, Fabian Aggeler wrote: >> --- a/target-arm/cpu.h >> +++ b/target-arm/cpu.h >> @@ -631,6 +631,7 @@ enum arm_features { >> ARM_FEATURE_CBAR, /* has cp15 CBAR */ >> ARM_FEATURE_CRC, /* ARMv8 CRC instructions */ >> AR

Re: [Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature for Security Extensions

2014-05-21 Thread Peter Maydell
On 21 May 2014 17:33, Sergey Fedorov wrote: > On 21.05.2014 20:14, Christopher Covington wrote: >> On 05/21/2014 10:46 AM, Peter Maydell wrote: >>> (Also I'm not sure what the semantics of -kernel should be for >>> TZ-supporting CPUs -- boot the kernel in S or NS ?) >> While Linux works in secure

Re: [Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature for Security Extensions

2014-05-21 Thread Sergey Fedorov
On 21.05.2014 20:41, Peter Maydell wrote: > If we want to have -kernel boot in NS then yes, the bootloader > stub is the place that code should go. > > The difficulty with -kernel being NS is that some guest kernels > for some boards may be assuming that they will run in secure state > and can dire

Re: [Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature for Security Extensions

2014-05-21 Thread Sergey Fedorov
On 21.05.2014 20:14, Christopher Covington wrote: > Hi Peter, > > On 05/21/2014 10:46 AM, Peter Maydell wrote: >> On 13 May 2014 17:15, Fabian Aggeler wrote: >>> From: Svetlana Fedoseeva >>> >>> Define Security Extensions CPU feature. Set that feature for relevant CPUs. >> This is potentially tri

Re: [Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature for Security Extensions

2014-05-21 Thread Christopher Covington
Hi Peter, On 05/21/2014 10:46 AM, Peter Maydell wrote: > On 13 May 2014 17:15, Fabian Aggeler wrote: >> From: Svetlana Fedoseeva >> >> Define Security Extensions CPU feature. Set that feature for relevant CPUs. > > This is potentially tricky because it means that CPUs which we were > previously

Re: [Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature for Security Extensions

2014-05-21 Thread Peter Maydell
On 13 May 2014 17:15, Fabian Aggeler wrote: > --- a/target-arm/cpu.h > +++ b/target-arm/cpu.h > @@ -631,6 +631,7 @@ enum arm_features { > ARM_FEATURE_CBAR, /* has cp15 CBAR */ > ARM_FEATURE_CRC, /* ARMv8 CRC instructions */ > ARM_FEATURE_CBAR_RO, /* has cp15 CBAR and it is read-only

Re: [Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature for Security Extensions

2014-05-21 Thread Peter Maydell
On 13 May 2014 17:15, Fabian Aggeler wrote: > From: Svetlana Fedoseeva > > Define Security Extensions CPU feature. Set that feature for relevant CPUs. This is potentially tricky because it means that CPUs which we were previously implementing without TZ now boot up with TZ and in Secure mode; I

[Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature for Security Extensions

2014-05-13 Thread Fabian Aggeler
From: Svetlana Fedoseeva Define Security Extensions CPU feature. Set that feature for relevant CPUs. Signed-off-by: Svetlana Fedoseeva Signed-off-by: Sergey Fedorov Signed-off-by: Fabian Aggeler --- target-arm/cpu.c | 4 target-arm/cpu.h | 1 + 2 files changed, 5 insertions(+) diff --g