Re: [Qemu-devel] [PATCH v2 02/10] qcow2/bitmap: avoid adjusting bm->flags for RO bitmaps

2018-06-20 Thread Vladimir Sementsov-Ogievskiy
13.06.2018 05:06, John Snow wrote: Instead of always setting IN_USE, do this conditionally based on whether or not the bitmap is read-only. Eliminate the two-pass processing and move the second loop to the failure case. This will allow us to show the flags exactly as they appear on-disk for bitm

[Qemu-devel] [PATCH v2 02/10] qcow2/bitmap: avoid adjusting bm->flags for RO bitmaps

2018-06-12 Thread John Snow
Instead of always setting IN_USE, do this conditionally based on whether or not the bitmap is read-only. Eliminate the two-pass processing and move the second loop to the failure case. This will allow us to show the flags exactly as they appear on-disk for bitmaps in `qemu-img info`. Signed-off-b