Re: [Qemu-devel] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct

2016-07-01 Thread John Snow
On 06/30/2016 09:03 AM, Alberto Garcia wrote: > On Wed 29 Jun 2016 07:20:55 PM CEST, Max Reitz wrote: > I thought adding a new 'ID' field was simpler. The device name is > still a device name (where it makes sense). The default ID is > guaranteed to be valid and guaranteed not to clas

Re: [Qemu-devel] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct

2016-06-30 Thread Alberto Garcia
On Wed 29 Jun 2016 07:20:55 PM CEST, Max Reitz wrote: I thought adding a new 'ID' field was simpler. The device name is still a device name (where it makes sense). The default ID is guaranteed to be valid and guaranteed not to clash with user-defined IDs. The API is (in my opini

Re: [Qemu-devel] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct

2016-06-29 Thread Max Reitz
On 23.06.2016 14:47, Alberto Garcia wrote: > On Wed 22 Jun 2016 05:49:28 PM CEST, Kevin Wolf wrote: >>> I thought adding a new 'ID' field was simpler. The device name is >>> still a device name (where it makes sense). The default ID is >>> guaranteed to be valid and guaranteed not to clash with use

Re: [Qemu-devel] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct

2016-06-23 Thread Alberto Garcia
On Wed 22 Jun 2016 05:49:28 PM CEST, Kevin Wolf wrote: >> I thought adding a new 'ID' field was simpler. The device name is >> still a device name (where it makes sense). The default ID is >> guaranteed to be valid and guaranteed not to clash with user-defined >> IDs. The API is (in my opinion) mor

Re: [Qemu-devel] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct

2016-06-22 Thread Kevin Wolf
Am 22.06.2016 um 16:42 hat Alberto Garcia geschrieben: > On Wed 22 Jun 2016 02:42:24 PM CEST, Kevin Wolf wrote: > >> We want block jobs to have unique, arbitrary identifiers that are not > >> tied to a block device, so this patch decouples the ID from the > >> device name in the BlockJob structure.

Re: [Qemu-devel] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct

2016-06-22 Thread Alberto Garcia
On Wed 22 Jun 2016 02:42:24 PM CEST, Kevin Wolf wrote: >> We want block jobs to have unique, arbitrary identifiers that are not >> tied to a block device, so this patch decouples the ID from the >> device name in the BlockJob structure. >> >> The ID is generated automatically for the moment, in la

Re: [Qemu-devel] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct

2016-06-22 Thread Kevin Wolf
Am 22.06.2016 um 14:24 hat Alberto Garcia geschrieben: > Block jobs are identified by the name of the BlockBackend of the BDS > where the job was started. Let me rephrase that: Block jobs are identified by an ID which defaults to the name of the BlockBackend where the job was started and can't cur

[Qemu-devel] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct

2016-06-22 Thread Alberto Garcia
Block jobs are identified by the name of the BlockBackend of the BDS where the job was started. We want block jobs to have unique, arbitrary identifiers that are not tied to a block device, so this patch decouples the ID from the device name in the BlockJob structure. The ID is generated automati