Re: [Qemu-devel] [PATCH v2 02/16] sockets: move qapi_copy_SocketAddress into qemu-sockets.c

2015-10-20 Thread Daniel P. Berrange
On Tue, Oct 20, 2015 at 02:08:09PM +0200, Paolo Bonzini wrote: > > > On 20/10/2015 00:05, Eric Blake wrote: > > > -qiv = qmp_input_visitor_new(obj); > > > -iv = qmp_input_get_visitor(qiv); > > > -visit_type_SocketAddress(iv, p_dest, NULL, _abort); > > > -

Re: [Qemu-devel] [PATCH v2 02/16] sockets: move qapi_copy_SocketAddress into qemu-sockets.c

2015-10-20 Thread Paolo Bonzini
On 20/10/2015 00:05, Eric Blake wrote: > > -qiv = qmp_input_visitor_new(obj); > > -iv = qmp_input_get_visitor(qiv); > > -visit_type_SocketAddress(iv, p_dest, NULL, _abort); > > -qmp_input_visitor_cleanup(qiv); > > -qobject_decref(obj); > Interesting approach - it means that

Re: [Qemu-devel] [PATCH v2 02/16] sockets: move qapi_copy_SocketAddress into qemu-sockets.c

2015-10-19 Thread Eric Blake
On 10/12/2015 05:14 AM, Daniel P. Berrange wrote: > The qapi_copy_SocketAddress method is going to be useful > in more places than just qemu-char.c, so move it into > the qemu-sockets.c file to allow its reuse. > > Signed-off-by: Daniel P. Berrange > --- >

[Qemu-devel] [PATCH v2 02/16] sockets: move qapi_copy_SocketAddress into qemu-sockets.c

2015-10-12 Thread Daniel P. Berrange
The qapi_copy_SocketAddress method is going to be useful in more places than just qemu-char.c, so move it into the qemu-sockets.c file to allow its reuse. Signed-off-by: Daniel P. Berrange --- include/qemu/sockets.h | 4 qemu-char.c| 25