Re: [Qemu-devel] [PATCH v2 03/10] qcow2/bitmap: cache bm_list

2018-06-21 Thread John Snow
On 06/21/2018 06:25 AM, Vladimir Sementsov-Ogievskiy wrote: >> > > agree. and this is one more reason to not load bitmaps in inactive mode > at all. and drop them (after storing) on inactivating. > I'll make a patch. Sure. I guess persistent bitmaps that exist when BDRV_O_INACTIVE is set need

Re: [Qemu-devel] [PATCH v2 03/10] qcow2/bitmap: cache bm_list

2018-06-21 Thread Vladimir Sementsov-Ogievskiy
21.06.2018 02:29, John Snow wrote: On 06/20/2018 09:04 AM, Vladimir Sementsov-Ogievskiy wrote: 13.06.2018 05:06, John Snow wrote: We don't need to re-read this list every time, exactly. We can keep it cached and delete our copy when we flush to disk. Because we don't try to flush bitmaps on

Re: [Qemu-devel] [PATCH v2 03/10] qcow2/bitmap: cache bm_list

2018-06-20 Thread John Snow
On 06/20/2018 09:04 AM, Vladimir Sementsov-Ogievskiy wrote: > 13.06.2018 05:06, John Snow wrote: >> We don't need to re-read this list every time, exactly. We can keep it >> cached >> and delete our copy when we flush to disk. >> >> Because we don't try to flush bitmaps on close if there's

Re: [Qemu-devel] [PATCH v2 03/10] qcow2/bitmap: cache bm_list

2018-06-20 Thread Vladimir Sementsov-Ogievskiy
20.06.2018 16:04, Vladimir Sementsov-Ogievskiy wrote: 13.06.2018 05:06, John Snow wrote: We don't need to re-read this list every time, exactly. We can keep it cached and delete our copy when we flush to disk. Because we don't try to flush bitmaps on close if there's nothing to flush, add a

Re: [Qemu-devel] [PATCH v2 03/10] qcow2/bitmap: cache bm_list

2018-06-20 Thread Vladimir Sementsov-Ogievskiy
13.06.2018 05:06, John Snow wrote: We don't need to re-read this list every time, exactly. We can keep it cached and delete our copy when we flush to disk. Because we don't try to flush bitmaps on close if there's nothing to flush, add a new conditional to delete the state anyway for a clean

[Qemu-devel] [PATCH v2 03/10] qcow2/bitmap: cache bm_list

2018-06-12 Thread John Snow
We don't need to re-read this list every time, exactly. We can keep it cached and delete our copy when we flush to disk. Because we don't try to flush bitmaps on close if there's nothing to flush, add a new conditional to delete the state anyway for a clean exit. Signed-off-by: John Snow ---