Re: [Qemu-devel] [PATCH v2 03/10] vl: Reject invalid class names on -global

2016-06-23 Thread Eduardo Habkost
On Thu, Jun 23, 2016 at 08:40:41AM -0300, Eduardo Habkost wrote: > On Thu, Jun 23, 2016 at 09:52:12AM +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > > Instead of just printing a warning very late, reject obviously > > > invalid -global arguments by validating the class name.

Re: [Qemu-devel] [PATCH v2 03/10] vl: Reject invalid class names on -global

2016-06-23 Thread Eduardo Habkost
On Mon, Jun 20, 2016 at 12:52:56PM -0300, Eduardo Habkost wrote: > Instead of just printing a warning very late, reject obviously > invalid -global arguments by validating the class name. > > Update test-qdev-global-props to not expect class name validation > to be performed in qdev_prop_check_glo

Re: [Qemu-devel] [PATCH v2 03/10] vl: Reject invalid class names on -global

2016-06-23 Thread Eduardo Habkost
On Thu, Jun 23, 2016 at 09:52:12AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Instead of just printing a warning very late, reject obviously > > invalid -global arguments by validating the class name. > > > > Update test-qdev-global-props to not expect class name validation >

Re: [Qemu-devel] [PATCH v2 03/10] vl: Reject invalid class names on -global

2016-06-23 Thread Markus Armbruster
Eduardo Habkost writes: > Instead of just printing a warning very late, reject obviously > invalid -global arguments by validating the class name. > > Update test-qdev-global-props to not expect class name validation > to be performed in qdev_prop_check_globals(). > > Reviewed-by: Markus Armbrust

[Qemu-devel] [PATCH v2 03/10] vl: Reject invalid class names on -global

2016-06-20 Thread Eduardo Habkost
Instead of just printing a warning very late, reject obviously invalid -global arguments by validating the class name. Update test-qdev-global-props to not expect class name validation to be performed in qdev_prop_check_globals(). Reviewed-by: Markus Armbruster Signed-off-by: Eduardo Habkost --