Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben:
> Finding snapshot by a name which could also be an id isn't best way
> how to do it. There will be rewrite of savevm, loadvm and delvm to
> improve the behavior of these commands. The savevm and loadvm will
> have their own patch series.
>
> No
δΊ 2013-4-25 20:16, Eric Blake ει:
On 04/25/2013 12:31 AM, Wenchao Xia wrote:
+
+if (!found) {
+error_setg(errp, "Failed to find snapshot '%s'", name ? name : id);
suggest not to set error, since it is a normal case.
The way I understand it, failure to find a snapshot might ne
On 04/25/2013 12:31 AM, Wenchao Xia wrote:
>
>> +
>> +if (!found) {
>> +error_setg(errp, "Failed to find snapshot '%s'", name ? name : id);
> suggest not to set error, since it is a normal case.
The way I understand it, failure to find a snapshot might need to be
treated as an error
On 25.4.2013 08:46, Pavel Hrdina wrote:
On 24.4.2013 23:26, Eric Blake wrote:
On 04/24/2013 09:32 AM, Pavel Hrdina wrote:
Finding snapshot by a name which could also be an id isn't best way
how to do it. There will be rewrite of savevm, loadvm and delvm to
improve the behavior of these commands
On 25.4.2013 08:31, Wenchao Xia wrote:
>> Finding snapshot by a name which could also be an id isn't best way
>> how to do it. There will be rewrite of savevm, loadvm and delvm to
>> improve the behavior of these commands. The savevm and loadvm will
>> have their own patch series.
>>
>> Now bdrv_sn
On 24.4.2013 23:26, Eric Blake wrote:
On 04/24/2013 09:32 AM, Pavel Hrdina wrote:
Finding snapshot by a name which could also be an id isn't best way
how to do it. There will be rewrite of savevm, loadvm and delvm to
improve the behavior of these commands. The savevm and loadvm will
have their o
> Finding snapshot by a name which could also be an id isn't best way
> how to do it. There will be rewrite of savevm, loadvm and delvm to
> improve the behavior of these commands. The savevm and loadvm will
> have their own patch series.
>
> Now bdrv_snapshot_find takes more parameters. The name
On 04/24/2013 09:32 AM, Pavel Hrdina wrote:
> Finding snapshot by a name which could also be an id isn't best way
> how to do it. There will be rewrite of savevm, loadvm and delvm to
> improve the behavior of these commands. The savevm and loadvm will
> have their own patch series.
>
> Now bdrv_sn
Finding snapshot by a name which could also be an id isn't best way
how to do it. There will be rewrite of savevm, loadvm and delvm to
improve the behavior of these commands. The savevm and loadvm will
have their own patch series.
Now bdrv_snapshot_find takes more parameters. The name parameter wi